Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to Hide Sensitive Data with ise_debug Enabled #118

Open
isrferna opened this issue Feb 15, 2024 · 0 comments
Open

Option to Hide Sensitive Data with ise_debug Enabled #118

isrferna opened this issue Feb 15, 2024 · 0 comments

Comments

@isrferna
Copy link

Is your feature request related to a problem? Please describe.
When ise_debug is set to true, sensitive data is shown in the logs:

p=1848853 u=admin n=ansible | TASK [Join node to the domain - ise-1] **********************************************************************************************************************************************************************
p=1848941 u=admin n=ciscoisesdk.restsession | Attempt 1
p=1848941 u=admin n=ciscoisesdk.restsession | 
Request
	URL: https://ise-1.example.local/ers/config/activedirectory/bbbe31f0-cc2e-11ee-b1a2-e2d8227a83b5/join
	Method: PUT
	Headers: 
		User-Agent: python-requests/2.31.0
		Accept-Encoding: gzip, deflate
		Accept: application/json
		Connection: keep-alive
		authorization: Basic YWRtaW46UDQkJHcwcmQh
		Content-type: application/json;charset=utf-8
	Params:
              {}
	Body:
            {
                "OperationAdditionalData": {
                    "additionalData": [
                        {
                            "name": "username",
                            "value": "Administrator"
                        },
                        {
                            "name": "password",
                            "value": "P4$$w0rd!"
                        },
                        {
                            "name": "node",
                            "value": "ise-1.example.local"
                        }
                    ]
                }
            }

Describe the solution you'd like
It would be great if a parameter, such as no_log: true, could be passed to hide the sensitive information, resulting in something like this:

p=1848853 u=admin n=ansible | TASK [Join node to the domain - ise-1] **********************************************************************************************************************************************************************
p=1848941 u=admin n=ciscoisesdk.restsession | Attempt 1
p=1848941 u=admin n=ciscoisesdk.restsession | 
Request
	URL: https://ise-1.example.local/ers/config/activedirectory/bbbe31f0-cc2e-11ee-b1a2-e2d8227a83b5/join
	Method: PUT
	Headers: 
		User-Agent: python-requests/2.31.0
		Accept-Encoding: gzip, deflate
		Accept: application/json
		Connection: keep-alive
		authorization: Basic VALUE_SPECIFIED_IN_NO_LOG_PARAMETER
		Content-type: application/json;charset=utf-8
	Params:
              {}
	Body:
            {
                "OperationAdditionalData": {
                    "additionalData": [
                        {
                            "name": "username",
                            "value": "Administrator"
                        },
                        {
                            "name": "password",
                            "value": VALUE_SPECIFIED_IN_NO_LOG_PARAMETER
                        },
                        {
                            "name": "node",
                            "value": "ise-1.example.local"
                        }
                    ]
                }
            }

Describe alternatives you've considered
An alternative solution to ensure that sensitive information is not disclosed in the log files would be to set ise_debug to false. However, this would mean losing the valuable information that helps us troubleshoot when something is not working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant