Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinned requests library is vulnerable #56

Closed
atlas-pouriya opened this issue Sep 19, 2023 · 3 comments
Closed

pinned requests library is vulnerable #56

atlas-pouriya opened this issue Sep 19, 2023 · 3 comments

Comments

@atlas-pouriya
Copy link

Hi,

I was wondering if there's any specific reason to pin the requests version to ">=2.27.1, <=2.28"?

Since version 2.0.10 we've been using requests version "2.31.0" without any issues.

Here's the link to the vulnerability report.

@tepene
Copy link

tepene commented Jan 12, 2024

And the ciscoisesdk can't be installed in an ansible project which uses ansible-lint in a version newer than 6.16.1.

vscode ➜ /workspaces/cisco_ise_operation (release/1.0.0) $ poetry add ciscoisesdk
Skipping virtualenv creation, as specified in config file.
Using version ^2.1.2 for ciscoisesdk

Updating dependencies
Resolving dependencies... (14.5s)

Because no versions of ciscoisesdk match >2.1.2,<3.0.0
 and ciscoisesdk (2.1.2) depends on requests (>=2.27.1,<=2.28), ciscoisesdk (>=2.1.2,<3.0.0) requires requests (>=2.27.1,<=2.28).
And because ansible-lint (6.21.1) depends on requests (>=2.31.0), ciscoisesdk (>=2.1.2,<3.0.0) is incompatible with ansible-lint (6.21.1).
So, because ansible depends on both ciscoisesdk (^2.1.2) and ansible-lint (6.21.1), version solving failed.

@bvargasre
Copy link
Contributor

Hi @atlas-pouriya

The restriction of requests >=2.27.1, <=2.28 has been removed. I am going to close the issue, in case of any problem feel free to reopen the issue or create a new one
Regards

@atlas-pouriya
Copy link
Author

Thanks @bvargasre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants