Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: archive page style fixes #124

Merged
merged 2 commits into from
Dec 27, 2022
Merged

fix: archive page style fixes #124

merged 2 commits into from
Dec 27, 2022

Conversation

melniiv
Copy link
Contributor

@melniiv melniiv commented Dec 27, 2022

Description

  • Fix search field outline styles to match all other search fields
  • Fix tags safari issues
  • Fix archive page layout overlapping issue in safari
  • Fix footer to be in the bottom of the page when not enough content loaded

Issues

Closes

DEV-XXX:

Related

Testing

Automated tests

Manual testing

Screenshots

Additional notes

@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
66.7% 66.7% Duplication

@github-actions
Copy link
Contributor

Events-Helsinki branch is deployed to: https://tapahtumat-helsinki-124.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Hobbies-Helsinki branch is deployed to: https://harrastus-helsinki-124.test.kuva.hel.ninja 🚀🚀🚀

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Merging #124 (92b9bfe) into main (8b0ccd5) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   60.43%   60.43%           
=======================================
  Files         370      370           
  Lines        8710     8710           
  Branches     1989     1989           
=======================================
  Hits         5264     5264           
  Misses       3242     3242           
  Partials      204      204           
Impacted Files Coverage Δ
...i/src/common-events/utils/headless-cms/service.tsx 0.00% <0.00%> (ø)
...i/src/common-events/utils/headless-cms/service.tsx 0.00% <0.00%> (ø)
...i/src/common-events/utils/headless-cms/service.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

TestCafe result is success for https://tapahtumat-helsinki-124.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

sports-Helsinki branch is deployed to: https://liikunta-helsinki-124.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr124.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is failure for https://harrastus-helsinki-124.test.kuva.hel.ninja! 😿💢💥💥

@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
100.0% 100.0% Duplication

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr124.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr124.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://liikunta-helsinki-124.test.kuva.hel.ninja! 😆🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants