Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: grey placeholders in form components #128

Merged
merged 8 commits into from
Dec 29, 2022
Merged

feat: grey placeholders in form components #128

merged 8 commits into from
Dec 29, 2022

Conversation

melniiv
Copy link
Contributor

@melniiv melniiv commented Dec 29, 2022 •
edited

Description

-When no values selected the placeholder color should be consistent
-Fixed Iphone input component colors (random blue)

image

Issues

Closes

DEV-XXX:

Related

Testing

Automated tests

Manual testing

Screenshots

Additional notes

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022 •
edited

Codecov Report

Merging #128 (d5b18b2) into main (04d95d5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   59.85%   59.85%           
=======================================
  Files         370      370           
  Lines        8794     8794           
  Branches     1998     1998           
=======================================
  Hits         5264     5264           
  Misses       3317     3317           
  Partials      213      213

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Events-Helsinki branch is deployed to: https://tapahtumat-helsinki-128.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr128.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Hobbies-Helsinki branch is deployed to: https://harrastus-helsinki-128.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

sports-Helsinki branch is deployed to: https://liikunta-helsinki-128.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022 •
edited

TestCafe result is success for https://tapahtumat-helsinki-128.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://liikunta-helsinki-128.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr128.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

TestCafe result is success for https://harrastus-helsinki-128.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr128.dev.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr128.dev.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr128.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr128.dev.hel.ninja 🚀🚀🚀

@melniiv melniiv merged commit 6b95e83 into main Dec 29, 2022
@kristianjokela kristianjokela mentioned this pull request Jan 10, 2023
Merged
This was referenced Jan 11, 2023
Merged
Merged
Merged
Closed
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Closed
@github-actions github-actions bot mentioned this pull request Mar 17, 2023
Merged
This was referenced Mar 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomakela nikomakela nikomakela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@melniiv @codecov-commenter @terovirtanen @nikomakela