Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: archive page title improvements #692

Merged
merged 2 commits into from
May 21, 2024
Merged

fix: archive page title improvements #692

merged 2 commits into from
May 21, 2024

Conversation

melniiv
Copy link
Contributor

@melniiv melniiv commented May 20, 2024

Description

Archive title uses the page title prop with fallback to config value

Issues

Closes

DEV-XXX:

Related

Testing

Automated tests

Manual testing

Screenshots

Additional notes

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr692.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr692.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr692.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://liikunta-pr692.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://harrastukset-pr692.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tapahtumat-pr692.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr692.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr692.dev.hel.ninja 🚀🚀🚀

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.0% Coverage on New Code (required ≥ 65%)
4.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
63.8% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr692.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr692.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr692.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://liikunta-pr692.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tapahtumat-pr692.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://harrastukset-pr692.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr692.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr692.dev.hel.ninja 🚀🚀🚀

@melniiv melniiv merged commit 766b0c4 into main May 21, 2024
114 checks passed
This was referenced May 21, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karisal-anders karisal-anders karisal-anders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@melniiv @terovirtanen @karisal-anders