fix: non-date string crash in trainingCompensationEndDate #2262
Conversation
|
API branch is deployed to platta: https://helsinkilisa-pr2262.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2262.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr2262.dev.hel.ninja 😆🎉🎉🎉 |
|
API branch is deployed to platta: https://helsinkilisa-pr2262.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2262.dev.hel.ninja 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2262.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr2262.dev.hel.ninja 😆🎉🎉🎉 |
rikuke
force-pushed
the
HL-910-date-input
branch
from
263e0d5
to
7165210
Compare
|
[yjdh] Kudos, SonarCloud Quality Gate passed!
|
|
[yjdh] Kudos, SonarCloud Quality Gate passed!
|
|
[yjdh] Kudos, SonarCloud Quality Gate passed!
|
|
[yjdh] Kudos, SonarCloud Quality Gate passed! |
|
API branch is deployed to platta: https://helsinkilisa-pr2262.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2262.dev.hel.ninja 🚀🚀🚀 |
|
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2262.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr2262.dev.hel.ninja 😆🎉🎉🎉 |
Description ✨
User is able to input anything into the handler application training compensation end date field and it crashes the app.
This happens because the getCorrectEndDate() function returns undefined when it cannot convert either of the supplied date strings into dates. This PR fixes the issue by making the return value optional.
Issues 🐛
Testing ⚗️
Navigate to the handler application and into an application that has one or more training compensation rows, try to type something into the training compensation end date.
Screenshots 📸
Additional notes 🗒️