Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hl 1005 fix #2403

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Hl 1005 fix #2403

merged 2 commits into from
Nov 1, 2023

Conversation

sirtawast
Copy link
Collaborator

Description ✨

Hotfix HL-1005

@sirtawast sirtawast merged commit c1776b9 into main Nov 1, 2023
25 of 35 checks passed
@sirtawast sirtawast deleted the hl-1005-fix branch November 1, 2023 07:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 190 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

75.3% 75.3% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2403.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2403.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2403.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2403.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2403.dev.hel.ninja 😆🎉🎉🎉

sirtawast added a commit that referenced this pull request Nov 9, 2023
@sirtawast
fix: check for field is touched AND has an error; HL-1005 (#2379, #2403)
d9bd311 
* refactor: rename file to use styled-components extension

* fix: rather than isValid, check if any field is touched AND has an error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sirtawast @terovirtanen