fix: require confirmation on attachment removal and when cancelling edit #2875

sirtawast · 2024-03-12T09:09:04Z

Description ✨

Add a couple of missing nags with window.confirm(). It's lacking the cool HDS modal styles but at least it's working 😏

Also set default paper application date if it's untouched.

terovirtanen · 2024-03-12T09:22:43Z

API branch is deployed to platta: https://helsinkilisa-pr2875.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-03-12T09:38:37Z

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T09:45:06Z

TestCafe result is success for https://helsinkilisa-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T12:37:27Z

API branch is deployed to platta: https://tet-pr2875.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-03-12T12:41:11Z

API branch is deployed to platta: https://kesaseteli-pr2875.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-03-12T12:41:12Z

API branch is deployed to platta: https://helsinkilisa-pr2875.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-03-12T12:53:15Z

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T12:54:13Z

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T12:56:42Z

TestCafe result is success for https://tet-admin-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T12:59:02Z

TestCafe result is success for https://kesaseteli-employer-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T13:01:04Z

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T13:07:16Z

TestCafe result is success for https://helsinkilisa-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T13:12:18Z

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T13:15:20Z

TestCafe result is success for https://kesaseteli-handler-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T13:19:01Z

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T13:22:07Z

TestCafe result is success for https://tet-youth-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T13:22:58Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T13:27:18Z

TestCafe result is success for https://helsinkilisa-ui-handler-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T13:28:14Z

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T13:44:27Z

TestCafe result is success for https://kesaseteli-youth-pr2875.dev.hel.ninja 😆🎉🎉🎉

EmiliaMakelaVincit

One typing mishap aside, seems fine.

EmiliaMakelaVincit · 2024-03-12T14:34:47Z

...fit/handler/src/components/applicationForm/formContent/attachmentsList/useAttachmentsList.ts

@@ -14,13 +14,14 @@ type ExtendedComponentProps = {
  attachments: [];
  isRemoving: boolean;
  isUploading: boolean;
-  handleRemove: (attachmentId: string) => void;
+  handleRemove: (attachmentId: string, name: string) => void;


The signature of the actual returned function didn't change; there's no name parameter there. The name is resolved inside that function by using the ID alone.

sonarcloud · 2024-03-12T15:04:32Z

Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud · 2024-03-12T15:05:41Z

Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-03-12T15:07:53Z

Quality Gate passed for 'yjdh'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-03-12T15:08:00Z

Quality Gate passed for 'yjdh'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-03-12T15:08:51Z

Quality Gate passed for 'yjdh'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-03-12T15:09:19Z

Quality Gate passed for 'yjdh'

Issues
23 New issues
7 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-03-12T15:09:29Z

Quality Gate passed for 'yjdh-tet-admin'

Issues
100 New issues
2 Accepted issues

Measures
0 Security Hotspots
53.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

terovirtanen · 2024-03-12T15:09:40Z

API branch is deployed to platta: https://kesaseteli-pr2875.api.dev.hel.ninja/healthz 🚀🚀🚀

sonarcloud · 2024-03-12T15:09:54Z

Quality Gate passed

Issues
35 New issues
1 Accepted issue

Measures
0 Security Hotspots
71.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-03-12T15:10:45Z

Quality Gate passed for 'yjdh-tet-youth'

Issues
72 New issues
1 Accepted issue

Measures
0 Security Hotspots
29.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-03-12T15:11:23Z

Quality Gate passed for 'yjdh-tet-shared'

Issues
43 New issues
1 Accepted issue

Measures
0 Security Hotspots
42.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-03-12T15:12:20Z

Quality Gate passed for 'yjdh'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-03-12T15:13:05Z

Quality Gate passed for 'yjdh'

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

terovirtanen · 2024-03-12T15:13:22Z

API branch is deployed to platta: https://tet-pr2875.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-03-12T15:14:47Z

API branch is deployed to platta: https://helsinkilisa-pr2875.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-03-12T15:22:25Z

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T15:27:30Z

TestCafe result is success for https://kesaseteli-employer-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T15:27:38Z

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T15:30:56Z

TestCafe result is success for https://tet-admin-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T15:31:05Z

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T15:37:05Z

TestCafe result is success for https://helsinkilisa-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T15:41:00Z

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T15:43:52Z

TestCafe result is success for https://kesaseteli-handler-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T15:52:04Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T15:53:07Z

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T15:55:51Z

TestCafe result is success for https://tet-youth-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T15:56:20Z

TestCafe result is success for https://helsinkilisa-ui-handler-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-03-12T15:57:42Z

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2875.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-03-12T16:23:51Z

TestCafe result is success for https://kesaseteli-youth-pr2875.dev.hel.ninja 😆🎉🎉🎉

sirtawast requested a review from EmiliaMakelaVincit March 12, 2024 09:09

sirtawast changed the title ~~Hl add remove nag~~ fix: require confirmation on attachment removal and when cancelling edit Mar 12, 2024

sirtawast force-pushed the hl-add-remove-nag branch from a5307be to cf3a478 Compare March 12, 2024 12:26

EmiliaMakelaVincit approved these changes Mar 12, 2024

View reviewed changes

sirtawast added 3 commits March 12, 2024 17:01

feat: require user confirmation on attachment deletion event

c5fbf5e

fix: add forgotten translation on cancel confirmation

9484a49

fix: set paper application date to today if it's undefined

9118842

sirtawast force-pushed the hl-add-remove-nag branch from cf3a478 to 9118842 Compare March 12, 2024 15:01

sirtawast merged commit b8de140 into main Mar 13, 2024
197 checks passed

sirtawast deleted the hl-add-remove-nag branch March 13, 2024 08:27

github-actions bot mentioned this pull request Mar 13, 2024

chore(main): release benefit-handler 3.3.0 [skip azp] #2850

Merged

fix: require confirmation on attachment removal and when cancelling edit #2875

fix: require confirmation on attachment removal and when cancelling edit #2875

Conversation

sirtawast commented Mar 12, 2024

Description ✨

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://helsinkilisa-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://tet-admin-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://kesaseteli-employer-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://helsinkilisa-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://kesaseteli-handler-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://tet-youth-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://helsinkilisa-ui-handler-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://kesaseteli-youth-pr2875.dev.hel.ninja 😆🎉🎉🎉

EmiliaMakelaVincit left a comment

Choose a reason for hiding this comment

EmiliaMakelaVincit Mar 12, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Mar 12, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Mar 12, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Mar 12, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Mar 12, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Mar 12, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Mar 12, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Mar 12, 2024

Quality Gate passed for 'yjdh-tet-admin'

terovirtanen commented Mar 12, 2024

sonarcloud bot commented Mar 12, 2024

Quality Gate passed

sonarcloud bot commented Mar 12, 2024

Quality Gate passed for 'yjdh-tet-youth'

sonarcloud bot commented Mar 12, 2024

Quality Gate passed for 'yjdh-tet-shared'

sonarcloud bot commented Mar 12, 2024

Quality Gate passed for 'yjdh'

sonarcloud bot commented Mar 12, 2024

Quality Gate passed for 'yjdh'

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://kesaseteli-employer-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://tet-admin-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://helsinkilisa-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://kesaseteli-handler-pr2875.dev.hel.ninja 😆🎉🎉🎉

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

terovirtanen commented Mar 12, 2024

TestCafe result is success for https://tet-youth-ui-pr2875.dev.hel.ninja 😆🎉🎉🎉