Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add reminder about alterations to applicant main page (HL-1100) #2927

Merged
merged 1 commit into from
Apr 15, 2024
Merged

feat: add reminder about alterations to applicant main page (HL-1100) #2927

merged 1 commit into from
Apr 15, 2024

Conversation

EmiliaMakelaVincit
Copy link
Collaborator

Description ✨

Adds a reminder box about reporting changes to employment. Only shown with the feature flag on.

Additional notes 🗒️

Swedish and final English translations are pending.

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2927.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2927.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2927.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2927.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2927.dev.hel.ninja 😆🎉🎉🎉

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
22 New issues
7 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2927.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2927.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2927.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2927.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2927.dev.hel.ninja 😿💢💥💥

1 similar comment
@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2927.dev.hel.ninja 😿💢💥💥

@EmiliaMakelaVincit EmiliaMakelaVincit merged commit bc04999 into main Apr 15, 2024
63 of 65 checks passed
@EmiliaMakelaVincit EmiliaMakelaVincit deleted the HL-1100-alteration-info-box branch April 15, 2024 12:19
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Merged
@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr2927.dev.hel.ninja 😿💢💥💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikuke rikuke rikuke approved these changes

@sirtawast sirtawast Awaiting requested review from sirtawast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EmiliaMakelaVincit @terovirtanen @rikuke