Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added underline text decoration for links in the content #1088

Closed
dmundra opened this issue Mar 27, 2023 · 3 comments · Fixed by #1093
Closed

Added underline text decoration for links in the content #1088

dmundra opened this issue Mar 27, 2023 · 3 comments · Fixed by #1093
Assignees

Comments

@dmundra
Copy link
Collaborator

dmundra commented Mar 27, 2023

Request from @mgifford

@dmundra dmundra self-assigned this Mar 27, 2023
@mgifford
Copy link
Contributor

mgifford commented Mar 27, 2023

Yes, this isn't a best practice:

Screenshot from our guidebook

While this is:

Screenshot from a GDS page

https://design-system.service.gov.uk/get-started/focus-states/

Maybe we don't need to do as excellent a job as the GDS. Here are some ideas I proposed on Drupal.org about links https://www.drupal.org/project/bartik/issues/1993574

Also see:

@mgifford
Copy link
Contributor

mgifford commented Mar 27, 2023

This is much, much better: a { color: inherit } than what we have now, which is { color: inherit; text-decoration: none; }

@dmundra is this just a matter of adding it here https://github.com/CivicActions/guidebook/blob/master/assets/css/extra.css and overriding what is in main.css?

@dmundra
Copy link
Collaborator Author

dmundra commented Mar 27, 2023

Yup @mgifford that is the approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants