You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the problem or limitation you are having
When modifying config which is supplied to the init.setup function with a new option such as: require("cmake-tools").setup({ ... cmake_generate_options={ ..., "-DFOO=1"}, ... })
The new option won't be loaded when there already exist a cache for a given project. Seemingly thanks to this line in init.lua: config.base_settings = vim.tbl_deep_extend("keep", old_config.base_settings, config.base_settings)
This was confusing for a new user (me) and forced me to investigate it in the code. Describe the solution you'd like
Don't know if it is an intended behavior, if it is really so, then it would be worth mentioning it (highlighted) in the config
section of README.
Describe alternatives you've considered
vim.tbl_deep_extend("force", old_config.base_settings, config.base_settings)
Additional context
The text was updated successfully, but these errors were encountered:
I understand your concern. Currently, for a new project, it will firstly initialize a session file which include generate_options, build_options, build_dir etc. Then, if you open this project again, it will reuse this session file.
Don't know if it is an intended behavior, if it is really so, then it would be worth mentioning it (highlighted) in the config
section of README.
So to say, it is an indended behaviour, I will highlight it in the config section of README.
Describe the problem or limitation you are having
When modifying config which is supplied to the init.setup function with a new option such as:
require("cmake-tools").setup({ ... cmake_generate_options={ ..., "-DFOO=1"}, ... })
The new option won't be loaded when there already exist a cache for a given project. Seemingly thanks to this line in init.lua:
config.base_settings = vim.tbl_deep_extend("keep", old_config.base_settings, config.base_settings)
This was confusing for a new user (me) and forced me to investigate it in the code.
Describe the solution you'd like
Don't know if it is an intended behavior, if it is really so, then it would be worth mentioning it (highlighted) in the config
section of README.
Describe alternatives you've considered
vim.tbl_deep_extend("force", old_config.base_settings, config.base_settings)
Additional context
The text was updated successfully, but these errors were encountered: