Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"objtool: no non-local symbols !?" after LLVM commit badd088c57d7d #1639

Closed
nathanchance opened this issue May 16, 2022 · 4 comments
Closed

"objtool: no non-local symbols !?" after LLVM commit badd088c57d7d #1639

nathanchance opened this issue May 16, 2022 · 4 comments
Labels
[BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.19 This bug was fixed in Linux 5.19 Reported upstream This bug was filed on LLVM’s issue tracker, Phabricator, or the kernel mailing list. [TOOL] objtool warning is produced by the kernel's objtool

Comments

@nathanchance
Copy link
Member

When building x86_64 allmodconfig on linux-5.17.y after commit 60d2b0b1018a ("objtool: Fix code relocs vs weak symbols") + llvm/llvm-project@badd088, I see objtool warnings/errors along the lines of

security/tomoyo/load_policy.o: warning: objtool: no non-local symbols !?
security/tomoyo/load_policy.o: warning: objtool: gelf_update_symshndx: invalid section index
make[3]: *** [scripts/Makefile.build:288: security/tomoyo/load_policy.o] Error 255

I have started a thread upstream around this: https://lore.kernel.org/YoK4U9RgQ9N+HhXJ@dev-arch.thelio-3990X/
@nathanchance nathanchance added [TOOL] objtool warning is produced by the kernel's objtool [BUG] llvm (main) A bug in an unreleased version of LLVM (this label is appropriate for regressions) Reported upstream This bug was filed on LLVM’s issue tracker, Phabricator, or the kernel mailing list. labels May 16, 2022
@nathanchance
Copy link
Member Author

Peter has a diff that fixes this:

https://lore.kernel.org/YoPCTEYjoPqE4ZxB@hirez.programming.kicks-ass.net/

It is in his personal repo for testing but it is aimed at 5.18:

https://git.kernel.org/peterz/queue/c/3a4e1c50c5a4d4f6bdf6fde5c569ba0247a9d8fc

@nathanchance nathanchance added [BUG] linux A bug that should be fixed in the mainline kernel. [PATCH] Accepted A submitted patch has been accepted upstream and removed [BUG] llvm (main) A bug in an unreleased version of LLVM (this label is appropriate for regressions) labels May 18, 2022
@nathanchance
Copy link
Member Author

Now in -tip: https://git.kernel.org/tip/d3f526155da9529d61663fcff19ca0e707dc2077

@nathanchance
Copy link
Member Author

Merged into mainline: https://git.kernel.org/linus/ead165fa1042247b033afad7be4be9b815d04ade

It is tagged for stable so it should go back automatically. 5.15 will need a backport, I'll handle it if nobody else does.

@nathanchance nathanchance added [FIXED][LINUX] 5.19 This bug was fixed in Linux 5.19 and removed [PATCH] Accepted A submitted patch has been accepted upstream labels May 26, 2022
@nathanchance
Copy link
Member Author

On its way back to 5.15:

https://git.kernel.org/stable/stable-queue/c/1b4b9958569b20c0bfe26da55f3a2d041dbf37a9
https://git.kernel.org/stable/stable-queue/c/4c8ff68984c48856b735499e61fda9493d8d04ff
https://git.kernel.org/stable/stable-queue/c/d60e4eff6810c99b87433d388939d6c1208347f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.19 This bug was fixed in Linux 5.19 Reported upstream This bug was filed on LLVM’s issue tracker, Phabricator, or the kernel mailing list. [TOOL] objtool warning is produced by the kernel's objtool
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance