Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wunused-const-variable in drivers/input/touchscreen/atmel_mxt_ts.c #527

Closed
nhukc opened this issue Jun 12, 2019 · 2 comments
Closed

-Wunused-const-variable in drivers/input/touchscreen/atmel_mxt_ts.c #527

nhukc opened this issue Jun 12, 2019 · 2 comments
Assignees
@nhukc
Labels
-Wunused-const-variable [ARCH] arm64 This bug impacts ARCH=arm64 [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.3 This bug was fixed in Linux 5.3

Comments

@nhukc
Copy link

nhukc commented Jun 12, 2019 

drivers/input/touchscreen/atmel_mxt_ts.c:259:42: warning: unused variable 'mxt_video_fops' [-Wunused-const-variable]
static const struct v4l2_file_operations mxt_video_fops = {
                                         ^

Variable is only used inside an ifdef. It should probably be moved inside the ifdef. V4L2 only seems supported for T37 and mxt_video_fops looks specific to V4L2.

#ifdef CONFIG_TOUCHSCREEN_ATMEL_MXT_T37
@nhukc nhukc added [BUG] linux A bug that should be fixed in the mainline kernel. [ARCH] arm64 This bug impacts ARCH=arm64 low priority This bug is not critical and not a priority -Wunused-const-variable labels Jun 12, 2019
@nhukc nhukc self-assigned this Jun 12, 2019
@nhukc nhukc added the [PATCH] Submitted A patch has been submitted for review label Jun 12, 2019
@nhukc
Copy link
Author

nhukc commented Jun 13, 2019

patch: https://groups.google.com/forum/#!topic/clang-built-linux/dF0M5G4-qOY

@nhukc nhukc added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Jul 1, 2019
@nickdesaulniers
Copy link
Member

mainline: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5cecc2bccc03f5f7b496b43a80fd5b768d44f13c

@nickdesaulniers nickdesaulniers added [FIXED][LINUX] 5.3 This bug was fixed in Linux 5.3 and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Jul 15, 2019
@tpimh tpimh removed the low priority This bug is not critical and not a priority label Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhukc nhukc

Labels
-Wunused-const-variable [ARCH] arm64 This bug impacts ARCH=arm64 [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.3 This bug was fixed in Linux 5.3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tpimh @nickdesaulniers @nhukc