Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Wunused-const-variable in drivers/net/wireless/ti/wl18xx/main.c #530

Closed
nhukc opened this issue Jun 12, 2019 · 3 comments
Closed

-Wunused-const-variable in drivers/net/wireless/ti/wl18xx/main.c #530

nhukc opened this issue Jun 12, 2019 · 3 comments
Assignees
Labels
-Wunused-const-variable [ARCH] arm64 This bug impacts ARCH=arm64 [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.3 This bug was fixed in Linux 5.3

Comments

@nhukc
Copy link

nhukc commented Jun 12, 2019

drivers/net/wireless/ti/wl18xx/main.c:1850:43: warning: unused variable 'wl18xx_iface_ap_cl_limits' [-Wunused-const-variable]
static const struct ieee80211_iface_limit wl18xx_iface_ap_cl_limits[] = {
                                          ^
drivers/net/wireless/ti/wl18xx/main.c:1869:43: warning: unused variable 'wl18xx_iface_ap_go_limits' [-Wunused-const-variable]
static const struct ieee80211_iface_limit wl18xx_iface_ap_go_limits[] = {
                                          ^

Introduced by 7845af3. These appear to be the limit definitions when using p2p devices. These limits are never actually used, but it looks like they should be.

static const struct ieee80211_iface_limit wl18xx_iface_ap_cl_limits[] = {
	{
		.max = 1,
		.types = BIT(NL80211_IFTYPE_STATION),
	},
	{
		.max = 1,
		.types = BIT(NL80211_IFTYPE_AP),
	},
	{
		.max = 1,
		.types = BIT(NL80211_IFTYPE_P2P_CLIENT),
	},
	{
		.max = 1,
		.types = BIT(NL80211_IFTYPE_P2P_DEVICE),
	},
};

static const struct ieee80211_iface_limit wl18xx_iface_ap_go_limits[] = {
	{
		.max = 1,
		.types = BIT(NL80211_IFTYPE_STATION),
	},
	{
		.max = 1,
		.types = BIT(NL80211_IFTYPE_AP),
	},
	{
		.max = 1,
		.types = BIT(NL80211_IFTYPE_P2P_GO),
	},
	{
		.max = 1,
		.types = BIT(NL80211_IFTYPE_P2P_DEVICE),
	},
};
@nhukc nhukc added [BUG] linux A bug that should be fixed in the mainline kernel. [ARCH] arm64 This bug impacts ARCH=arm64 low priority This bug is not critical and not a priority -Wunused-const-variable labels Jun 12, 2019
@nhukc nhukc self-assigned this Jun 12, 2019
@nhukc
Copy link
Author

nhukc commented Jun 13, 2019

Reached out to author+maintainer: https://groups.google.com/forum/#!topic/clang-built-linux/1Lu1GT9ic94

@nhukc nhukc added the [PATCH] Submitted A patch has been submitted for review label Jun 14, 2019
@nhukc nhukc added [PATCH] Accepted A submitted patch has been accepted upstream and removed [PATCH] Submitted A patch has been submitted for review labels Jun 24, 2019
@nickdesaulniers nickdesaulniers added [FIXED][LINUX] 5.3 This bug was fixed in Linux 5.3 and removed [PATCH] Accepted A submitted patch has been accepted upstream labels Jul 21, 2019
@tpimh tpimh removed the low priority This bug is not critical and not a priority label Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Wunused-const-variable [ARCH] arm64 This bug impacts ARCH=arm64 [BUG] linux A bug that should be fixed in the mainline kernel. [FIXED][LINUX] 5.3 This bug was fixed in Linux 5.3
Projects
None yet
Development

No branches or pull requests

3 participants