Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with PHP <7 - plugin is not deactivated #20

Closed
xxsimoxx opened this issue Nov 24, 2019 · 2 comments
Closed

Bug with PHP <7 - plugin is not deactivated #20

xxsimoxx opened this issue Nov 24, 2019 · 2 comments
Assignees
@timbocode
Labels
Bug Something isn't working, displaying properly or is producing an error
Milestone
Version 1.0.0-Beta1

Comments

@xxsimoxx
Copy link
Member

When activating with lower version of PHP the error message is correctly displayed, but the plugin is not deactivated.

The problem seems here.

Just replacing CPSEO_FILE with __FILE__ solves it.
@timbocode timbocode added the Bug Something isn't working, displaying properly or is producing an error label Nov 24, 2019
@timbocode
Copy link
Contributor

Thanks @xxsimoxx . Yes, of course, CPSEO_FILE is defined after it is called so that's not going to work too well is it? :)

Thanks for reporting this. I'll create a fix shortly.

@timbocode timbocode self-assigned this Nov 25, 2019
timbocode added a commit that referenced this issue Nov 25, 2019
@timbocode
Fix for #20: Plugin is not automatically deactivated when using PHP <…
f1288cd 
… 7.0
@timbocode
Copy link
Contributor

Fixed in release 0.3.3

@timbocode timbocode added this to the Version 1.0.0 milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timbocode timbocode

Labels
Bug Something isn't working, displaying properly or is producing an error
Projects
None yet
Milestone
Version 1.0.0-Beta1
Development

No branches or pull requests
2 participants
@timbocode @xxsimoxx