New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic PRs for new ClassicPress and WordPress versions #18
Comments
I've been experimenting with
The code below hopefully makes the substitution more specific, it handles the 'other' versions more specifically and it also handles the WP release versioning better. It may well be clunky and I expected more improvements can be made but posting here so there is a record and starting point.
|
@mattyrob is there a place for us to test this? |
@bahiirwa It is possible to test step wise in in Linux command line. With higher confidence in what we have we can create and tweak the workflow later if needed. |
We should set up a bot to make new PRs to this repository when new ClassicPress or WordPress versions are released, to enable the new version for the migration plugin.
There are 2 cases to handle:
New ClassicPress versionaddressed in #38The ClassicPress migration plugin needs to use a ClassicPress build with a different structure, because WordPress can only do an upgrade from a zip file that contains a single folder namedwordpress
. (Some history and links at ClassicPress/ClassicPress#148.)To avoid an extra manual step in the release process, we generate these migration builds along with the nightly builds: https://github.com/ClassyBot/ClassicPress-nightly/releasesA new nightly build is released every day shortly after midnight UTC.We need to create a PR against this repository every time the nightly build changes to a new base version number, indicating that a release has been done. Here is an example of such a commit: 348751dNew WordPress version
An initial attempt at this was made in #36 and #38 but it needs more work before being committed, see 9a480d6 for more info.
When a new version of WordPress is released this also needs to be tested manually (because a new WP version could break the migration process) and then enabled.
An automated PR could be created for this too, though again it needs to be tested carefully before being merged.
Here are two examples of such commits, they should look a bit different depending on whether it was a major or a minor version of WordPress that was released:
The text was updated successfully, but these errors were encountered: