Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

馃悶 Quick Edit break columns #166

Closed
xxsimoxx opened this issue Aug 3, 2023 · 10 comments 路 Fixed by #171
Closed

馃悶 Quick Edit break columns #166

xxsimoxx opened this issue Aug 3, 2023 · 10 comments 路 Fixed by #171
Labels
status: discussion type: bug Something isn't working

Comments

@xxsimoxx
Copy link
Member

xxsimoxx commented Aug 3, 2023

Expected behavior

No column shift.

Current behavior

Originally reported by Avias on the forum:
https://forums.classicpress.net/t/classic-seo-2-2-0-alpha-0-help-testing/4836/5
https://forums.classicpress.net/t/classic-seo-2-2-0-alpha-0-help-testing/4836/7

After quick editing a post, the post column is shifted.

image image image

Possible solution

No response

Steps to reproduce bug

  1. Go to "Posts -> All posts" or "Pages -> All Pages"
  2. Make sure the "ID" column is showing
  3. "Quick edit" a post (change title, author or something else)
  4. Click on update

Context

No response

ClassicPress version

2.0.0-dev

PHP version

8.1

Can you help?

I can help test a solution

@xxsimoxx xxsimoxx added status: needs triage This issue needs revision, splitting, or other gardening work type: bug Something isn't working labels Aug 3, 2023
@ClassyBot
Copy link
Contributor

This issue has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/classic-seo-2-2-0-alpha-0-help-testing/4836/8

@viktorix
Copy link
Member

viktorix commented Aug 3, 2023

Based on this message, I think it's PHP 8.2:
https://forums.classicpress.net/t/conversion-to-2-0/4874/5?u=viktor

@xxsimoxx
Copy link
Member Author

xxsimoxx commented Aug 3, 2023

I've reproduced this also with PHP 7.4 and 8.1.

@viktorix viktorix added status: discussion and removed status: needs triage This issue needs revision, splitting, or other gardening work labels Aug 3, 2023
@viktorix
Copy link
Member

viktorix commented Aug 3, 2023

@mattyrob
Copy link
Collaborator

mattyrob commented Aug 3, 2023

Is this browser specific? I cannot reproduce in Safari on Mac locally.

@viktorix
Copy link
Member

viktorix commented Aug 3, 2023

I'm using Brave (Chromium), where I can reproduce the issue.

@viktorix
Copy link
Member

viktorix commented Aug 3, 2023

I was able to replicate issue in Firefox.

@mattyrob
Copy link
Collaborator

mattyrob commented Aug 3, 2023

I am still unable to reproduce locally in Chrome or Firefox.

Does it make any difference if you run grunt js-dependencies locally?

@viktorix
Copy link
Member

viktorix commented Aug 3, 2023

Maybe Simone can try grunt command. I'm on Windows and can't use grunt. Here's a GIF of what happens:

eae2c915-9989-4041-b937-69ca42d2769d

@mattyrob
Copy link
Collaborator

mattyrob commented Aug 5, 2023

I spent some time carefully reviewing this and managed to recreate the issue and also confirm that the fix applied seems to resolve the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: discussion type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants