Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Status report to show both CC and WC version numbers #145

Closed
timbocode opened this issue Dec 17, 2019 · 2 comments
Closed

Update Status report to show both CC and WC version numbers #145

timbocode opened this issue Dec 17, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@timbocode
Copy link
Contributor

Is your feature request related to a problem? Please describe.
At present, the status report only shows the WC version and not the CC version. See #143 .

Describe the solution you'd like
Show both versions.

Additional context
Related to issue #143


A few minor changes required:

In includes/class-woocommerce.php, below public $version = '3.5.3'; add

public $cc_version = '0.1.0';

In includes/api/v2/class-wc-rest-system-status-v2-controller.php, add

'cc_version' => WC()->cc_version,

in the return array in get_environment_info() (line 614 approx).

In includes/admin/views/html-admin-page-status-report.php (approx line 67), change as follows:

<tr>
  <td data-export-label="CC Version"><?php esc_html_e( 'Classic Commerce version', 'classic-commerce' ); ?>:</td>
  <td class="help"><?php echo wc_help_tip( esc_html__( 'The version of Classic Commerce installed on your site.', 'classic-commerce' ) ); /* phpcs:ignore WordPress.XSS.EscapeOutput.OutputNotEscaped */ ?></td>
  <td><?php echo esc_html( $environment['cc_version'] ); ?></td>
</tr>
<tr>
  <td data-export-label="WC Version"><?php esc_html_e( 'WooCommerce version', 'classic-commerce' ); ?>:</td>
  <td class="help"><?php echo wc_help_tip( esc_html__( 'The version of WooCommerce installed on your site.', 'classic-commerce' ) ); /* phpcs:ignore WordPress.XSS.EscapeOutput.OutputNotEscaped */ ?></td>
  <td><?php echo esc_html( $environment['version'] ); ?></td>
</tr>
@timbocode timbocode added the enhancement New feature or request label Dec 17, 2019
@timbocode timbocode added this to the Version 1.0.0 milestone Dec 17, 2019
@timbocode timbocode added the Has PR Issue has a PR. label Dec 17, 2019
@timbocode
Copy link
Contributor Author

PR #146

@timbocode timbocode self-assigned this Dec 17, 2019
@timbocode
Copy link
Contributor Author

Closed with PR #146

@timbocode timbocode removed the Has PR Issue has a PR. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant