Fix the icon is not being displayed

[ridemountainpig]

Resolved issue #89

Before

After

[0xDylan]

i honestly cannot believe how simple this fix was lol
nice one!

[hunghg255]

GitHub changed from text to link to edit file, nice PR

[deffcolony]

confirmed its working

[TylerAustInW]

i installed this today, and it seems the issues back, i've uninstalled/disabled all other extensions to see if it was a conflict and wasn't working either.

[ridemountainpig]

i installed this today, and it seems the issues back, i've uninstalled/disabled all other extensions to see if it was a conflict and wasn't working either.

This pull request has not been merged and published to the Chrome Web Store, so the issue persists. We need to wait for @Claudiohbsantos, the repository's author, to update it.

[TylerAustInW]

i installed this today, and it seems the issues back, i've uninstalled/disabled all other extensions to see if it was a conflict and wasn't working either.

This pull request has not been merged and published to the Chrome Web Store, so the issue persists. We need to wait for @Claudiohbsantos, the repository's author, to update it.

Gotcha, thank you it's early and i didn't even realize that. thank you for the confirmation

[kryota-dev]

Good job!
Confirmed that the fix is working fine.

[csandman]

I love how everyone is approving this change that has no authority to actually approve it 😅

[TylerAustInW]

I love how everyone is approving this change that has no authority to actually approve it 😅

lmao that's exactly what i've been thinking

[kleo-dev]

Please post a release

[TylerAustInW]

Honestly doubt this will ever maintained again, So might as well fork it and add a fix for yourself

[vsnthdev]

Honestly doubt this will ever maintained again, So might as well fork it and add a fix for yourself

Yup, looking at the activity it looks like, better off forking this project...

[ridemountainpig]

Honestly doubt this will ever maintained again, So might as well fork it and add a fix for yourself

The author of this project appears few to maintenance, so how about I creating an organization to fork the project, fix the issues, and republish it on the Chrome Web Store ?

Once that's done, we can maintain this extension.

[vsnthdev]

Honestly doubt this will ever maintained again, So might as well fork it and add a fix for yourself

The author of this project appears few to maintenance, so how about I creating an organization to fork the project, fix the issues, and republish it on the Chrome Web Store ?

Once that's done, we can maintain this extension.

I think you should do that 🙌 and maybe even change the extension's name and icon in order to not conflict the current extension in Chrome Store.

[TylerAustInW]

Believe that would be copyright, you can always fork it and keep it updated yourself, exactly what i did, i mean let alone it was just a simple class name fix anyways of changing the h3 to a so

have a fork of it on my profile as well.

[PKief]

I would also like to take part in the discussion. I am the author of the VS Code Material Icon Extension. I have decided to create an organisation in which both the browser addon and the VS Code Material Icon Extension can be further developed.

I have already applied for a new web extension for Chrome and Firefox and will continue to be responsible for the projects. I think the work of @Claudiohbsantos is great, and I would like the project to stay alive.

@Claudiohbsantos please let me know if you're fine with this decision, or if you've some concerns. I'd be happy to avoid any conflicts.

If you are interested in continuing to work on the addon and participating in the organisation, please contact me by email: philipp.kief@gmx.de. It'd be great if some contributors could support the development on these extensions 😊

[TylerAustInW]

great if some contributors could support th

i would Love to contribute to this, i used this a while about and then started having issues with it but never had the time to fix it, or look into it. Life happend (became a dad and everything) now everything is much more maintainable and working from home Now i'd Love to keep this alive

[deffcolony]

@PKief

As a long-time user of the VS Code Material Icon Extension, I truly appreciate the work you've done; it has made identifying icons much easier for me. I want to ensure this project stays alive and updated as well. Hopefully the maintainer will let u know soon

[davenaugler]

@PKief
I'd be happy to help.

[ridemountainpig]

@PKief
I'd be happy to contribute to the Material Extension too.

[PKief]

Good news, a new version with the fix (1.8.15) has been published to Google Chrome and Firefox already.

• Chrome: https://chromewebstore.google.com/detail/material-icons-for-github/bggfcpfjbdkhfhfmkjpbhnkhnpjjeomc
• Firefox: https://addons.mozilla.org/de/firefox/addon/material-icons-for-github

[davenaugler]

That chrome extension has resolved the issues. Thank you @PKief!

[TylerAustInW]

Good news, a new version with the fix (1.8.15) has been published to Google Chrome and Firefox already.

• Chrome: https://chromewebstore.google.com/detail/material-icons-for-web/hopghfcljkdgmajlhdfpgpcemcfhbili

• Firefox: https://addons.mozilla.org/de/firefox/addon/material-icons-for-web

Well done! Lets keep this alive shall we ... maybe some even new ideas to come 👀

[csandman]

@PKief If you are interested in continuing to work on the addon and participating in the organisation, please contact me by email: philipp.kief@gmx.de. It'd be great if some contributors could support the development on these extensions 😊

I just sent you an email about becoming a maintainer of your fork, if that becomes the primary version people use. I know that @Claudiohbsantos has been a bit sporadic with support over time so a fork might be the best route, and I've personally put in a lot of work into this project over the past couple years.

Here are some examples of things I have done for this project:

• I was the one who made the original change in the extension to add support for other git providers (Azure Devops and BitBucket): Add support for Azure DevOps and BitBucket #31
• After my initial change to add new git providers to the extension, I added support for three other providers, GitLab, Gitee, and SourceForge: Add support for GitLab, Gitee, and SourceForge #41
• I added the support for the new code view that GitHub added: GitHub Code View Support #56
• I provided Claudio with the proof of concept for the settings popup, which I made for the icon sizes, that he ultimately ended up using as his basis for the full feature: Icon size improvement #33 (comment)
• A few other smaller contributions over time, both responding to issues, and other smaller PRs that have been merged:
  • https://github.com/Claudiohbsantos/github-material-icons-extension/issues?q=author%3Acsandman+
  • https://github.com/Claudiohbsantos/github-material-icons-extension/issues?q=is%3Aissue+commenter%3Acsandman+

I also have some experience contributing to other chrome extensions. Specifically, the github-file-icons extension, which basically provides the same feature with a different icon pack. Most notably, that extension was using a very out-of-date version of the icon pack, so I updated it to pull in the most recent versions of the files from the source pack: homerchen19/github-file-icons#121

And you can see all of my other contributions here: https://github.com/homerchen19/github-file-icons/issues?q=author%3Acsandman

And finally, I also have some experience creating/maintaining my own open source projects. The most notable of which is my project chakra-react-select, which is used in close to 4k open source projects on GitHub, and receives over 110k downloads per week.

All that to say I think I'd make a good maintainer of the project if you'll have me!

[Claudiohbsantos]

Wow, I completely dropped the ball on this one. Thanks to everyone who stepped up to both propose these fixes and fork the project into an organization where it can be more actively maintained.

@ridemountainpig I will reopen this PR and merge just to cut a release with this fix for the users who might not be following this discussion and the move to a fork. I agree that moving the extension to a repo where it can be more actively maintained is the best path forward and don't really intend to branch off or continue development in this repo atm, but if I can at least make the cutover less painful for existing users that should be a plus. Thanks for opening this, and sorry it took me so long to see it

@PKief Thank you for chiming in and creating an organization. I completely support the move and think this will be the best for the project and, most importantly, for any users of the extension. I'll reach out to you directly to work out how we can make the migration the easiest possible. I'm particularly wondering if there's any way to safely change ownership of the extension in the app stores to avoid forcing users to have to realize this is all changing and re-downloading a new extension.

I'll also just add a strong note of recommendation for @csandman as a maintainerfor the new fork. To be completely honest most of the recent significant contributions to the functionality of this extension came from their work and their initiative so this extension has only worked for as long as it has because of their contributions.

I'll figure out how to best close out the loop on the remaining issues and gracefully archive the repo once migration is figured out and complete.

Thanks everyone who contributed to the discussion and with code and for the refreshingly civil discussions (I expected worse when I saw the number of mentions and realized I had completely forgotten about this repo for a while)