Include py.typed in the published package #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severo
added a commit
to huggingface/dataset-viewer
that referenced
this pull request
Feb 24, 2023
severo
added a commit
to huggingface/dataset-viewer
that referenced
this pull request
Feb 24, 2023
severo
added a commit
to huggingface/dataset-viewer
that referenced
this pull request
Feb 24, 2023
severo
added a commit
to huggingface/dataset-viewer
that referenced
this pull request
Feb 24, 2023
* chore: 🤖 upgrade dependencies to fix vulnerability also: upgrade huggingface_hub and other dependencies * fix: 🐛 fix types issue related to ClearcodeHQ/mirakuru#633 * chore: 🤖 ensure all the imports are covered
|
Not sure how to fix the CI error. https://github.com/ClearcodeHQ/mirakuru/actions/runs/4263150574/jobs/7419838723#step:2:609 |
Codecov ReportBase: 96.34% // Head: 96.34% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 20 20
Lines 903 903
=======================================
Hits 870 870
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@severo you'll need to run |
|
@severo thank you! |
severo
added a commit
to huggingface/dataset-viewer
that referenced
this pull request
Feb 28, 2023
since ClearcodeHQ/mirakuru#633 has been merged and released in 2.5.1
severo
added a commit
to huggingface/dataset-viewer
that referenced
this pull request
Feb 28, 2023
* reorganize executor * remove unused import * add pytz dep * add types-pytz dep * updating the other poetry lock files * Apply suggestions from code review Co-authored-by: Sylvain Lesage <sylvain.lesage@huggingface.co> * move dep to dev dep * move dep to dev dep * docstrings + get_job_with_id * raise BadWorkerState * get rid of with_id * style * poetry update for worker * Apply suggestions from code review Co-authored-by: Sylvain Lesage <sylvain.lesage@huggingface.co> * feat: 🎸 upgrade packages * docs: ✏️ add doc for WORKER_STATE_PATH * chore: 🤖 use only generic worker, and set the state directory * ci: 🎡 add the four new env vars to the chart * fix: 🐛 WORKER_STATE_PATH must be a fname, .lock will be app'd * chore: 🤖 use default temporary directory for storing the state * chore: 🤖 sync both docker-compose files * refactor: 💡 rename variables to make it clear we need a file * refactor: 💡 remove WORKER_STATE_FILE_PATH from the documentatio Recommand to use TMPDIR if it's important to setup where the temporary files are stored, but don't recommend to set up WORKER_STATE_FILE_PATH directly. * fix: 🐛 the worker executor has to setup the env variable * fix: 🐛 the executor sets the env var, the loop reads it * chore: 🤖 run mypy on mirakuru since ClearcodeHQ/mirakuru#633 has been merged and released in 2.5.1 --------- Co-authored-by: Quentin Lhoest <lhoest.q@gmail.com> Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
mattstern31
added a commit
to mattstern31/datasets-server-storage-admin
that referenced
this pull request
Nov 11, 2023
* chore: 🤖 upgrade dependencies to fix vulnerability also: upgrade huggingface_hub and other dependencies * fix: 🐛 fix types issue related to ClearcodeHQ/mirakuru#633 * chore: 🤖 ensure all the imports are covered
mattstern31
added a commit
to mattstern31/datasets-server-storage-admin
that referenced
this pull request
Nov 11, 2023
* reorganize executor * remove unused import * add pytz dep * add types-pytz dep * updating the other poetry lock files * Apply suggestions from code review Co-authored-by: Sylvain Lesage <sylvain.lesage@huggingface.co> * move dep to dev dep * move dep to dev dep * docstrings + get_job_with_id * raise BadWorkerState * get rid of with_id * style * poetry update for worker * Apply suggestions from code review Co-authored-by: Sylvain Lesage <sylvain.lesage@huggingface.co> * feat: 🎸 upgrade packages * docs: ✏️ add doc for WORKER_STATE_PATH * chore: 🤖 use only generic worker, and set the state directory * ci: 🎡 add the four new env vars to the chart * fix: 🐛 WORKER_STATE_PATH must be a fname, .lock will be app'd * chore: 🤖 use default temporary directory for storing the state * chore: 🤖 sync both docker-compose files * refactor: 💡 rename variables to make it clear we need a file * refactor: 💡 remove WORKER_STATE_FILE_PATH from the documentatio Recommand to use TMPDIR if it's important to setup where the temporary files are stored, but don't recommend to set up WORKER_STATE_FILE_PATH directly. * fix: 🐛 the worker executor has to setup the env variable * fix: 🐛 the executor sets the env var, the loop reads it * chore: 🤖 run mypy on mirakuru since ClearcodeHQ/mirakuru#633 has been merged and released in 2.5.1 --------- Co-authored-by: Quentin Lhoest <lhoest.q@gmail.com> Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.