SessionIndex is optional

[oldshuren]

I think SessionIndex in the response is optional. But now get_session_index() throws an error if SessionIndex is missing

[ashein]

This one. The schema states that the session attribute is optional, and some IdPs (e.g. salesforce) don't generate any indices here, so such valid asserts fail from the module's standpoint.

[cozmo]

Hey folks, you're correct that SessionIndex is optional, however for our use cases it's always provided (and we rely on that behavior for a few pieces of functionality) so I do not think we're going to be able to prioritize a fix here.

However we'd be more than happy to accept and review a PR that enables SessionIndex to be optional (maybe behind a flag?).

[cozmo]

Thanks to @jalleyne and #73 we now have an require_session_index option that's been deployed as version 1.8.0 on NPM. Closing this ticket now, but please comment/re-open if there's any issues with this. Thanks again to @jalleyne