Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory Tabs Mods Support #65

Closed
ardissaps opened this issue Jun 23, 2022 · 6 comments
Closed

Inventory Tabs Mods Support #65

ardissaps opened this issue Jun 23, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@ardissaps
Copy link

ardissaps commented Jun 23, 2022

Cannot press PlayerEx button, it trigger button beneath instead.
image
https://www.curseforge.com/minecraft/mc-mods/inventory-tabs-updated
Andrew6rant/InventoryTabs#15

@CleverNucleus
Copy link
Owner

Hi there,
I'll look to add support for Inventory Tabs.
Thanks.

@CleverNucleus CleverNucleus added the enhancement New feature or request label Jun 23, 2022
@Andrew6rant
Copy link

I've fixed the issue on InventoryTabs' side.

image

The mods are not fully integrated, clicking on any InventoryTab makes the PlayerEx tabs disappear (and vice versa), and both mods have a "home" tab for the player inventory, but there is no longer an overlap.

@CleverNucleus
Copy link
Owner

Hi there @Andrew6rant,
I really appreciate you coming up with a solution so quickly and saving me the time. I realise the mechanism by which I add my tabs is suboptimal at best, so thank you for your patience.

I consider this issue closed now, but if you want to work on further integration and need anything from me, please don't hesitate to ask.

@ardissaps
Copy link
Author

Oh great I am reinstalling PlayerEx now thank you for you guys!

@Andrew6rant
Copy link

I haven't released the fix yet, I was planning on dropping the update when I also had EasierCrafting and Scout support. I can push an update now, give me a few minutes

@Andrew6rant
Copy link

InventoryTabs-0.5.0-1.18.x has been released on CurseForge, Modrinth, and Github, with PlayerEx support and a fix for tabs not being removed when they should be inaccessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants