Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior with AppBarLayout #23

Closed
formatBCE opened this issue Mar 26, 2018 · 6 comments
Closed

Behavior with AppBarLayout #23

formatBCE opened this issue Mar 26, 2018 · 6 comments

Comments

@formatBCE
Copy link

Trying to use this lib together with AppBarLayout, to scroll Toolbar up before scrolling view itself. For this, i wrapped table containing layout to NestedScrollView, but can't achieve proper work - looks like TableLayout does not support such behavior. Could you please take a look?

@tifezh
Copy link

tifezh commented May 2, 2018

@formatBCE Did you solve it?

@formatBCE
Copy link
Author

@tifezh yes, i managed to make it working by forking and digging into code.
You may see my fork https://github.com/formatBCE/AdaptiveTableLayout,
but be aware, that a lot was changed there to support dynamic data sets as well.

@tnam0x
Copy link

tnam0x commented Jun 20, 2018

Could you tell me what part of code you changed to fix this issue?

@formatBCE
Copy link
Author

formatBCE commented Jun 22, 2018

@namtran4194 sorry for late response - had busy days.
Changes were made in AdaptiveTableLayout class:

  1. @Override public boolean onDown(MotionEvent e) { // stop smooth scrolling if (!mScrollerRunnable.isFinished()) { mScrollerRunnable.forceFinished(); } startNestedScroll(ViewCompat.SCROLL_AXIS_VERTICAL); return true; }
    here "startNestedScroll" was added.

  2. "scrollBy" method fixed - without that fix nested scroll was laggy as hell.

  3. All rows regarding to NestedScrollingChildHelper were added - field and methods, look at the end of file.

  4. "onScroll" and "onFling" methods.

I suppose, it's enough to get it working. If there's any troubles - inform me please, i will continue to dig.

@yarovoiag
Copy link
Contributor

Hi @formatBCE, thx for using this library.
I see you did a good job )) Feel free to create pull request. We will integrate this changes in our library.
With best regards Cleveroad team.

@formatBCE
Copy link
Author

Hey @yarovoiag! Will make it asap, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants