Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider CTE when parsing insert statement #817

Merged
merged 1 commit into from Jan 19, 2022
Merged

Consider CTE when parsing insert statement #817

merged 1 commit into from Jan 19, 2022

Conversation

zhicwu
Copy link
Contributor

@zhicwu zhicwu commented Jan 19, 2022

Closes #810

@zhicwu zhicwu linked an issue Jan 19, 2022 that may be closed by this pull request
CTE in INSERT INTO SELECT query triggers unexpected "Missing parameters" exception #810
Closed
@github-actions
Copy link 

Benchmark                                 (client)  (connection)  (statement)  (type)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20   242.021 ±  33.928  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20   231.347 ±  29.460  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20   226.394 ±  25.891  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20   227.974 ±  24.827  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   240.578 ±  29.520  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   241.820 ±  28.638  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20   237.228 ±  28.421  ops/s
Basic.insertOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   240.439 ±  28.336  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse       normal  object  thrpt   20  1610.439 ±  86.325  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1         reuse     prepared  object  thrpt   20  1679.701 ±  86.501  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new       normal  object  thrpt   20  1625.393 ±  80.651  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc1           new     prepared  object  thrpt   20  1644.987 ±  98.707  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20  1068.352 ±  64.290  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20  1049.235 ±  79.460  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new       normal  object  thrpt   20  1025.678 ± 104.439  ops/s
Basic.selectOneRandomNumber   clickhouse-grpc-jdbc           new     prepared  object  thrpt   20  1032.488 ± 105.036  ops/s

@zhicwu zhicwu merged commit fd3d923 into ClickHouse:develop Jan 19, 2022
@zhicwu zhicwu deleted the fix-parser-issue branch January 19, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CTE in INSERT INTO SELECT query triggers unexpected "Missing parameters" exception
1 participant
@zhicwu