Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NB: this.$dayspan.today.toMoment(...).locale is not a function #187

Closed
WolfgangAl opened this issue May 13, 2019 · 1 comment
Closed

NB: this.$dayspan.today.toMoment(...).locale is not a function #187

WolfgangAl opened this issue May 13, 2019 · 1 comment

Comments

@WolfgangAl
Copy link
Contributor

This isn't so much an issue as a word of warning; when you build dayspan-vuetify in your project and upgrade its dependency dayspan to the newest version (^0.12.5) you will get numerous errors stating the 'locale' function is not available in Moment objects. This is because in dayspan moment was changed to a peer dependency. It will now use the moment version in dayspan-vuetify, which is locked at version 2.7.0 (devDependencies). The solution is to change the dev dependency for moment in dayspan-vuetify/package.json to read "^2.24.0" like this:

  "devDependencies": {
  ...
  "moment": "^2.24.0",
  ...
}
@ClickerMonkey
Copy link
Owner

The moment dependency will be removed on the next release, it was removed from the latest release of dayspan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants