Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI (GH actions) workflow not triggered on pull request. #3

Closed
brews opened this issue Dec 14, 2020 · 0 comments · Fixed by #4
Closed

CI (GH actions) workflow not triggered on pull request. #3

brews opened this issue Dec 14, 2020 · 0 comments · Fixed by #4
Assignees
Labels
bug Something isn't working

Comments

@brews
Copy link
Member

brews commented Dec 14, 2020

Our currentCI workflow only triggers on push events. We need it to also trigger on pull request to main.

The addition should look something like this.

on:
  push:
    branches: "*"
  pull_request:
    branches: "main"

Should be an easy fix. We only triggered on push events because CI was just getting set up -- so we don't need to worry about breaking legacy behavior.

Stumbled across this in PR #2.

@brews brews added the bug Something isn't working label Dec 14, 2020
@brews brews self-assigned this Dec 14, 2020
@brews brews closed this as completed in #4 Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant