Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weights files are not deploying #187

Closed
delgadom opened this issue May 30, 2018 · 2 comments · Fixed by #442
Closed

weights files are not deploying #187

delgadom opened this issue May 30, 2018 · 2 comments · Fixed by #442
Assignees
@brews
Labels
bug

Comments

@delgadom
Copy link
Member

you screwed this up, @delgadom!!!
@delgadom delgadom added the bug label May 30, 2018
@delgadom
Copy link
Member Author

@brews everything in impactlab-tools/assets should be deployed, and then https://github.com/ClimateImpactLab/impactlab-tools/blob/master/impactlab_tools/utils/weighting.py#L17 needs to access the correct path

@brews brews self-assigned this Aug 28, 2019
@brews brews mentioned this issue Aug 29, 2019
Merged
5 tasks
@brews
Copy link
Member

brews commented Aug 29, 2019

If this pops up again for certain installs (cloud or something) we might want to swap in pkgutil.get_data() instead of building package resources paths to load in these assets. I just did the simplest fix, and we should be okay. Just FYI for our future selfs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brews brews

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug excluding assets from installed package
2 participants
@brews @delgadom