Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin geopandas to /label/dev #443

Open
delgadom opened this issue Aug 29, 2019 · 3 comments
Open

pin geopandas to /label/dev #443

delgadom opened this issue Aug 29, 2019 · 3 comments

Comments

@delgadom
Copy link
Member

@brews We only use conda-forge/label/dev::geopandas because it uses vectorized shape references that improve performance by >1000x for very large shapefiles, which we use heavily. This was a cython upgrade pathway that Matt Rocklin suggested for the geopandas devs, and unfortunately so far they have not taken up maintenence of that branch and the two packages have fallen out of sync. We'd like to maintain compatibility with the dev branch because the performance of the core package is unacceptable for a lot of our work.

This should apply across packages if you're working with a geopandas dependency. I don't think any lab packages explicitly require that version, but the two branches are getting further out of sync and we should probably start standardizing label/dev as a required build dependency.

Thanks!

@brews brews self-assigned this Aug 29, 2019
@brews
Copy link
Member

brews commented Aug 29, 2019

@delgadom you're saying, in short, we want to use conda install -c conda-forge/label/dev geopandas in production because it's faster.

Edit:

Any reason we couldn't push this feature into a current version of geopandas? ...assuming it's not too complex, and it wasn't given a hard block before by geopandas devs...

@brews brews removed their assignment Aug 29, 2019
@brews
Copy link
Member

brews commented Aug 30, 2019

To make this a hard requirement for our people we would have to build conda packages for the key packages and have that geopandas-dev link in the build recipe. I don't know another easy way to do this with a compiled dependency.

@delgadom
Copy link
Member Author

delgadom commented Sep 5, 2019

last time I checked it was given a hard block by the geopandas devs :(

I just looked through the geopandas issues again and it looks like there's been more activity lately, but this is still the recommended way to use it. I don't think taking it on ourselves is the right way forward... the people who are working on this are core geopandas/shapely/pydata developers and it seems like it's still a way off.

see https://github.com/geopandas/geopandas/labels/geopandas-cython

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants