Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smfGetYahooHistory close / adjclose using wrong pItem codes #19

Closed
ClimberMel opened this issue Feb 20, 2023 · 1 comment · Fixed by #20
Closed

smfGetYahooHistory close / adjclose using wrong pItem codes #19

ClimberMel opened this issue Feb 20, 2023 · 1 comment · Fixed by #20
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ClimberMel
Copy link
Owner

From Marek:
"A" isn't a valid parameter for the smfGetYahooHistory function. "C" is supposed to pull adjusted price. The documentation page from 2022: https://web.archive.org/web/20220706061313/http://ogres-crypt.com/SMF/Documentation/viewer.php?name=smfGetYahooHistory-Function.html

@ClimberMel
Copy link
Owner Author

Interesting mix up with the items list.
Marek mentioned that the Adjusted/Unadjusted closes were mixed up. I was using A for adjusted and C for unadjusted close.

I went back through the original code and smfGetYahooHistory used
pItems As String = "tdohlcvufgxs"
"Ticker,Date,Open,High,Low,Close,Volume,Unadj,Div Adj,Split Adj,Dividend,Split"
So Randy used Close (C) for adjusted close and (U) for Unadjusted Close in the smfGetYahooHistory.

What threw me off was that I started with RCHGetYahooHistory which accepts A for adjusted Close and C for unadjusted close but did a swap before calling smfGetYahooHistory.

The old smfGetYahooHistory didn't have a "A" item. But RCHGetYahooHistory did...

So I now have to figure out the best way to deal with this as I have tried to keep the original formulas working... so I will see about switching smfGetYahooHistory back to using C for adjClose and U for Close (unadjusted)

I'm not planning on trying to do the individual split adjusted and div adjusted calculations since yahoo provides the adjusted close now, I see no reason to attempt to try split them out. Especially since yahoo doesn't provide the splits and divs with the rest of the data.

I'll let everyone know when the new version gets posted and I will test to make sue it doesn't mess up what is already working...

@ClimberMel ClimberMel self-assigned this Feb 20, 2023
@ClimberMel ClimberMel added the bug Something isn't working label Feb 20, 2023
@ClimberMel ClimberMel added this to the New release milestone Feb 21, 2023
@ClimberMel ClimberMel linked a pull request Feb 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant