Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smfGetYahooPortfolioView possible incorrect data returned #9

Closed
ClimberMel opened this issue Feb 9, 2023 · 4 comments · Fixed by #20
Closed

smfGetYahooPortfolioView possible incorrect data returned #9

ClimberMel opened this issue Feb 9, 2023 · 4 comments · Fixed by #20
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ClimberMel
Copy link
Owner

I've just tried version 02.09 but it seems to produce incorrect results. For example here is a formula I am using to calculate the avg. annual return for VTSAX for the past 10 years:

 =(@smfGetYahooPortfolioView("VTSAX","15",,0)/@smfGetYahooHistory("VTSAX","2013-02-07","2013-02-08", "w","C",0,0))^(1/10)-1

It evaluates to 10.2% but it should produce 12.3% instead (checking against Morningstar and another financial information website).

Any thoughts?

Marek

@ClimberMel ClimberMel self-assigned this Feb 9, 2023
@ClimberMel
Copy link
Owner Author

image

@ClimberMel
Copy link
Owner Author

I thought it was pulling adj close in the other routines, so I will have to check why it isn't when called from this module.

@ClimberMel ClimberMel added the question Further information is requested label Feb 10, 2023
@ClimberMel
Copy link
Owner Author

While investigating this module, I did note that smfGetPortfolioView makes multiple calls to Yahoo to get the data one ticker at a time. The sURL that is created gets a json file for the entire request.
I need to check if it is actually retrieving the data again, or using cached data as some of the modules are able to do.
If it is using cached data, that is fine if it just loops through the results:0 through xx

@ClimberMel ClimberMel added this to the New release milestone Feb 21, 2023
@ClimberMel ClimberMel added bug Something isn't working and removed question Further information is requested labels Feb 21, 2023
@ClimberMel
Copy link
Owner Author

ClimberMel commented Feb 21, 2023

This is appears related to the mix up over the C = adjusted close and U = unadjusted close issue with smfGetYahooHistory since
Marek's formula also called smfGetYahooHistory. There is no issue currently with smfGetYahooHistory.

@ClimberMel ClimberMel linked a pull request Feb 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant