New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LIMITED score range #1554
Comments
Thanks, @wrightmw ! @ErinRiggs -- for discussion on Monday? |
@selinad Yes, this is definitely one for the list on a Monday call. |
This will be an issue for some of the HCM genes too. I am meeting with Jonathan in the morning and will ask for his input. |
Jenny spoke to Jonathan about this issue - he agreed that Limited should =0.1-6 (if and only if there is something entered into Genetic Evidence. For all other classifications, round up at 0.5 and higher, round down if less than 0.5. |
Thanks, @ErinRiggs. Is this change being made in the SOP as well? |
Addressing this ticket in the |
The requested changes in this ticket can be reviewed in the following instance: |
@jimmyzhen This looks good. Total scores between 0.1 and 0.9 are now marked as LIMITED. Only caveat is that if there is only Experimental Evidence there should be no Classification. |
@ErinRiggs Currently, if at least 1.0 is scored via any evidence type then a LIMITED Classification is calculated. Under the new rules within this ticket, if at least 0.1 is scored via any evidence type then a LIMITED Classification will be calculated. Implementing the feature whereby Genetic Evidence must be scored before any Classification can be calculated would be a new functionality within the Classification matrix, and this would require logic changes that could not be done before the next release (which is due next week). Would you like a note to be added to the Classification Matrix to advise curators that they should only use a Classification if they have some Genetic evidence? If so, what would you like this text to say? |
@jimmyzhen this works well! -- did you only modify the LIMITED range or should we check other transitions too? |
@selinad, I only modified the LIMITED range. What are you referring to in regards to transitions? |
Great! There was a note in there about behavior between LIMITED and MODERATE, etc. -- only confirming you didn't touch those as they were already set to be that way. Looks good! |
Updated! Works great. 0.1 with Score value gives LIMITED. thx, @jimmyzhen ! |
Range has been updated from 0.1. Great! |
Included in R16 release. |
The LIMITED score range in the GCI is currently 1 to 6. Incremental scores of 0.1 are now allowable in the GCI, so should the LIMITED score range be changed to 0.1 to 6 to reflect this?
The text was updated successfully, but these errors were encountered: