Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report view #18

Merged
merged 6 commits into from Nov 17, 2020
Merged

Report view #18

merged 6 commits into from Nov 17, 2020

Conversation

mayabrandi
Copy link
Contributor

@mayabrandi mayabrandi commented Nov 11, 2020

This PR adds content to the report view. Would be nice with some input from @elevu regarding exporting the view to pdf...

Review:

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@coveralls
Copy link

coveralls commented Nov 16, 2020

Coverage Status

Coverage decreased (-0.4%) to 49.85% when pulling e0e7533 on report_view into 7c84d90 on master.

@mayabrandi mayabrandi marked this pull request as ready for review November 16, 2020 13:50
@northwestwitch
Copy link
Member

@mayabrandi could you include the basic commands to run in order to test this? I can review!

Copy link
Member

@northwestwitch northwestwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's looking good!

One thing that you might add (also in another PR) is a button to go back to the main batch view if you are on one of the report pages. Or perhaps the easiest would be to open the reports on a new page..

@mayabrandi
Copy link
Contributor Author

mayabrandi commented Nov 17, 2020 via email

@mayabrandi mayabrandi merged commit 2bc4a02 into master Nov 17, 2020
@Mropat Mropat deleted the report_view branch October 22, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants