Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Docker a first class citizen #42

Merged
merged 1 commit into from Jun 19, 2019
Merged

Make Docker a first class citizen #42

merged 1 commit into from Jun 19, 2019

Conversation

fabiang
Copy link

@fabiang fabiang commented Jun 19, 2019

and allow Docker Hub to build the image from repository automatically.

I've change some things to make the project more useful when used together with Docker:

  • The configuration file can now contain environment variables
    • Most setups now can easily be configured without the requirement of passing a custom config file
    • Note: I've used github.com/drone/envsubst because that package supports default values for environment variables
  • The Dockerfile now is feature-complete; including git, a config with environment variables and the releases folder is now a volume
  • Based on this changes it's now possible to automatically create official Docker images via Docker Hub

I've tested the creation of Docker images ob Docker Hub based on tags/branches in a private repository.

@Clivern Clivern self-requested a review June 19, 2019 21:16
@Clivern Clivern added the enhancement New feature or request label Jun 19, 2019
@Clivern
Copy link
Owner

Clivern commented Jun 19, 2019

Thanks @fabiang for your PR. Adding envsubst is really a good idea!
within the next days I will use envsubst with config.dist.yml too, adding build dir & logs dir as volume too and Update README so it is clear how to override with environment vars & create a new release.

@Clivern Clivern merged commit c0817eb into Clivern:master Jun 19, 2019
@fabiang fabiang deleted the first-class-docker branch June 19, 2019 21:30
@fabiang
Copy link
Author

fabiang commented Jun 19, 2019

Let me know, when you need assitance with documentation

@Clivern
Copy link
Owner

Clivern commented Jun 19, 2019

Yeah, sure, thanks again @fabiang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants