Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Further improvement of Bubble sliders at very low brightness percentages #124

Closed
FrankJaco opened this issue Oct 23, 2023 · 2 comments

Comments

@FrankJaco
Copy link

FrankJaco commented Oct 23, 2023

v3.1.1 was a big step in the right direction with the icon area of the slider now lighting up slightly when the light is on at low percentages. But I don't think it is enough of an indicator yet. Below is both a Bubble slider and a Mushroom card slider for comparison:

Cards when light is off:

image

This comparison really shows how great the bubble card is for small screens! It takes up only 2/3 of the vertical size compared to the Mushroom in its small horizontal mode. And the Bubble provides full width sliding easily allowing two bubbles be placed side-by-side on a small screen with the slider fully usable! The Mushroom's short slider just is not practical in side-by-side configuration. BUT the mushroom card has the icon gray when the state is off. This makes it very easy to determine it is off.

Cards with light at 6% brightness in two different colors:
'
image
image

On small screens like a smartphone the Mushroom card icon area is very clear when a light is turned on even at a low percentage. The bubble's icon doesn't change at all and even the icon background area is only lit by a very small percentage.

My Bubble feature request is to "borrow" a couple of the Mushroom's features. Have the icon gray when the light is off; and lit (either white or in the light's color) when the light is on. Have the icon's background indicate the color of the light, but scale it brighter at small brightness percentages.

@Clooos
Copy link
Owner

Clooos commented Oct 23, 2023

Thanks for the comparison! I've never used Mushroom Cards and this is indeed a good example of how I can improve my icons more. I will do that in the next release!

@Clooos
Copy link
Owner

Clooos commented Oct 30, 2023

This is a new feature in v1.4.0 and up, thanks again!

@Clooos Clooos closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants