Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload issue popped up again #342

Closed
Nazze opened this issue Jan 7, 2024 · 53 comments
Closed

Reload issue popped up again #342

Nazze opened this issue Jan 7, 2024 · 53 comments
Labels
bug Something isn't working

Comments

@Nazze
Copy link

Nazze commented Jan 7, 2024

Describe the bug
The dashboard get into a reload-loop. And then gets stuck. It is the same issue we had previously. It is showing up on all versions of 1.6.x. And a downgrade to 1.5.3. does not seem to work..

To Reproduce
Steps to reproduce the behavior:

  1. Install version 1.6.3 with HACS
  2. Delete cache on all devices
  3. Reload the screen on the HA companion app for iOS
  4. Error appears (see video)

Expected behavior
It should reload once and remain stable

Screenshots
https://github.com/Clooos/Bubble-Card/assets/33813707/b7f16f4c-80d4-4491-a2a7-333091605b48

Smartphone (please complete the following information):

  • Device: iPhone 15 Pro
  • OS: iOS 17.2.1
  • Browser HA Companion app (default browser = Firefox)
  • Version 1.6.0, 1.6.2
@Nazze Nazze added bug Something isn't working bug? Something may not working? labels Jan 7, 2024
@Clooos
Copy link
Owner

Clooos commented Jan 7, 2024

Hi! I will fix that now once for good! 🍻

@Nazze
Copy link
Author

Nazze commented Jan 7, 2024

Where can I check the current Version of bubble cards? Because I am not sure if the download to 1.5.3. was successful.
If it was successful, I am not sure, if the latest version of mushroom cards triggers it. Will try to downgrade that, too.

@Clooos
Copy link
Owner

Clooos commented Jan 7, 2024

You can check the version in the Bubble Card editor 🙂

@Clooos Clooos removed the bug? Something may not working? label Jan 7, 2024
@Nazze
Copy link
Author

Nazze commented Jan 7, 2024

Oh yeah, it shows 1.6.1, although I explicitely selected 1.5.3 from HACS. Don't know, if this is an issue with HACS? Will reboot HA now and try again.

@Nazze
Copy link
Author

Nazze commented Jan 7, 2024

I don't know, why HACS was always downloading the latest version, although I picked 1.5.3.
I have overwritten the 2 files in www/comunity_files with the one from github and I could roll-back now to 1.5.3, which is stable for me.

BTW, the version information inside the js file is not correct, that's why it was showing "1.6.1" instead of "1.6.2" in the Bubble Card Editor..

@Clooos
Copy link
Owner

Clooos commented Jan 7, 2024

This is fixed in the new 1.6.3!

https://github.com/Clooos/Bubble-Card/releases/tag/v1.6.3

@Clooos Clooos closed this as completed Jan 7, 2024
@Nazze
Copy link
Author

Nazze commented Jan 7, 2024

Yeah, it's not crashing anymore, but the perfomance is slower than 1.5.3. But I understood that you are looking into performance issues #260

@bexem
Copy link

bexem commented Jan 7, 2024

Thank you for fixing it so quickly!
It has solved most of the reload issues for me on my iPhone but I’ve noticed that if I have a popup card with a webrtc camera stream in the Lovelace front end it will start the reload loop, to solve it I had to removed those cards (but I’ve kept other with more static content).
Not a big loss but except some oddities with the 1.5.3 it was working fine before updating to 1.6.x (and it does work fine on desktop).

Update: I’ve tried with the picture card and it does the same but I’ve noticed that if reduce the amount of popup cards with cameras [from 5 (with two of them display two feeds) to 3 (one of them is displaying two camera feed] (either webrtc or picture card) the loop doesn’t happen.

The iPhone is 15Pro, with latest iOS and Home Assistant app.

@Clooos Clooos reopened this Jan 10, 2024
@Clooos
Copy link
Owner

Clooos commented Jan 10, 2024

I've changed something related to the camera pop-ups, it might be the issue. I'm working on it!

@joaopedros2
Copy link

I am also having the same issue with version 1.6.3.

I have 3 popup cards, where one has 2 camera feeds from Frigate with go2rtc, and the other two have 1 feed each. What happens to me is that sometimes it plays all 4 simultaneously, and sometimes it doesn't open the popup itself...

@Nazze
Copy link
Author

Nazze commented Jan 18, 2024

This is fixed in the new 1.6.3!

https://github.com/Clooos/Bubble-Card/releases/tag/v1.6.3

Hey @Clooos ! I was running 1.6.4. for a day or two, but the reload is still happening. Had to revert to 1.5.3 again, which is stable for me.

@HAlover99
Copy link

Ciao Cloos,

reload loop it's still present also with the 1.6.4 version.

@holt3000
Copy link

@Clooos yea I've been having the iOS reload loop still as well. It appeared with 1.6x updates

@Clooos
Copy link
Owner

Clooos commented Jan 30, 2024

I'm still actively working on this issue, I will release a new beta as soon as possible.

@brainstorm82
Copy link

brainstorm82 commented Feb 14, 2024

@Clooos I run into this issue and investigated it. In my case it starts with a big set of popup elements >10 . When i reduce the popup down to max 10 it is working fine.

@HAlover99
Copy link

today i update to 1.7.0... issue still present...

@Clooos
Copy link
Owner

Clooos commented Feb 14, 2024

Thanks for your feedback, I'm still not sure of what is causing this. Do you have any related logs in Home Assistant or in your browser console? I really want to fix that!

@holt3000
Copy link

In the iOS companion app, going into settings>companion settings>debugging,>reset frontend cache, seemed to help this.

@HAlover99
Copy link

HAlover99 commented Feb 14, 2024

@holt3000
i already tried without success :( i don't understand because if use few popups work without problem...
I hope that @Clooos will found root cause, btw there is a strange behavior because with pc browser i don't have this issue, seems appear only with phone, this week i'll try to enable web inspector on Iphone and use MAC to using console to hope will found some error.

@Legrand5382
Copy link

My iPhone do the same, reload loop. Can’t use it at all. I was hoping this update would have fix it but unfortunatly not. I use a iPhone 14 Pro Max with latest IOS. Work perfectly fine on my iPads.

@Nazze
Copy link
Author

Nazze commented Feb 15, 2024

Hi! I had the issue again with 1.7.0, especially when swiping UP. But I cleared the cache a couple of times and I am not seeing it anymore. I hope it stays like this for the next couple of days. But so far, this is the best release, I've seen... I love it, @Clooos !

@hellomarb
Copy link

Can confirm that heavy dashboards with > 8 popups crash the iOS app scrolling down on my dashboard. When I remove 3 of them all is fine. They contain mini-media-player, apex charts and sankey-chart which are all memory heavy.
So looks like a memory issue on iOS.

@Gyldenlow
Copy link

Can also confirm that the reload loop is present. Goes away when i limit the number of pop-up cards to a max of 10.

iPhone 15 pro, bubble-card v1.70

@Clooos
Copy link
Owner

Clooos commented Feb 16, 2024

Thanks a lot for your feedback everyone, I will try to add more pop-ups on my test dashboard to reproduce this issue.

@Nazze
Copy link
Author

Nazze commented Feb 16, 2024

I actually had the issue today, too. But strangely it recovered and I am able to use the dashboard again.
iPhone 15 pro and HA companion app. No related logs seen.

@Clooos
Copy link
Owner

Clooos commented Feb 17, 2024

This is my guess too, just a question, do you have one or more cameras in your pop-ups? If yes what card do you use for that?

@Nazze
Copy link
Author

Nazze commented Feb 17, 2024

No, I am not using camera cards.

@Legrand5382
Copy link

No camera also here, a few small pictures on somes.

@Clooos
Copy link
Owner

Clooos commented Feb 17, 2024

This issue is my priority right now, I was able to replicate it on my iPad so it's a good start.

@Gyldenlow
Copy link

No cameras here either. Today I tried restarting my iPhone as suggested by @Nazze, which seemed to fix it for some time.

@Clooos
Copy link
Owner

Clooos commented Feb 19, 2024

I've released the new v1.7.1, but I can't say for sure that this is fixed.

https://github.com/Clooos/Bubble-Card/releases/tag/v1.7.1

Edit: After some more testing I haven't add a single reload issue since and everything seems to not slow down anymore after some time on iOS. I really think that this is finally fixed! 🤞

@holt3000
Copy link

Unfortunately still experiencing this issue @Clooos. I have 12 popups and one has a few cameras

@Legrand5382
Copy link

Same here, seem to stay longer then before but still go on loop after maybe 3-4 seconds.

@Clooos
Copy link
Owner

Clooos commented Feb 20, 2024

Even after clearing the cache / rebooted the iOS device? I really have no more issues.

But if it persists I still have an idea, but I just want to be sure that this is still an issue.

@Nazze
Copy link
Author

Nazze commented Feb 20, 2024

Last time it took a couple of days to show up. So I am still testing. But at the moment 1.7.1 looks stable to me.

@hellomarb
Copy link

Still an issue (without cameras in popups, but apex-charts + sankey charts + > 8 popups), crash on scroll.
I'm testing in a new copy of my installation, so frontend caching isn't the problem.

@Clooos
Copy link
Owner

Clooos commented Feb 20, 2024

I will release a test version here probably today. I might have an idea on how to fix that 🤞

@Gyldenlow
Copy link

I've had the bug happen only once after updating to 1.7. However, since rebooting my phone it has yet to appear again

@Clooos
Copy link
Owner

Clooos commented Feb 20, 2024

Here is a test version that I really hope could fix this issue, just install it with the Without HACS installation method.

This version is removing and recreating the content of each pop-ups when they are opened, so in theory even with 1000 pop-ups it should works 🤞 This part of the code was previously used for only removing the videos, so don't use the background_camera: true feature in this test version.

I can't wait to have your feedback on this!

bubble-card.js.zip

@hellomarb
Copy link

Yes, I can confirm that in my usecase the reload on scroll bug is solved by the new approach.
I will test it over the day, but for now it seems much faster and bubblecard isn't getting in the way of card_mod anymore while inital load.

Is there a branch with the src so I can build it on my own?
I put my css modifications in the core bubble-pop.js file to have it global for all popups (z-index issues and a lot of styling).

@Clooos
Copy link
Owner

Clooos commented Feb 20, 2024

I will modify this a bit and I will release that as the 1.7.2 version 🙂

@Clooos
Copy link
Owner

Clooos commented Feb 20, 2024

The update is now available!

https://github.com/Clooos/Bubble-Card/releases/tag/v1.7.2

@Gyldenlow
Copy link

Absolute chad 👆🏻

@Legrand5382
Copy link

This version work perfectly well on my iPhone (no more reload at all) and also seem faster on my Ipad, thank you for your wonderful work 😊

@Clooos
Copy link
Owner

Clooos commented Feb 20, 2024

Finally! I can rest in peace now! 🍻

@Clooos Clooos closed this as completed Feb 20, 2024
@holt3000
Copy link

Thanks @Clooos ! Great work

@Nazze
Copy link
Author

Nazze commented Feb 20, 2024

Man, it feels like a big step forward. I will monitor for a couple of days. But I think you deserve more beer already 😅🍻

@HAlover99
Copy link

Ciao Cloods

Refresh page solved but when try to open a popup-card loop start again.
I already clear cache and reboot iPhone.

@Clooos
Copy link
Owner

Clooos commented Feb 21, 2024

I had this issue too, BUT this is already fixed and I will release a new version soon!

Edit: The new update is available!

@Clooos
Copy link
Owner

Clooos commented Feb 26, 2024

This issue is still happening on some setups (like on my old iPad), but I've made significantly huge progresses on that. The next release is going to be lightning fast on every setups!

@Clooos Clooos reopened this Feb 26, 2024
@Clooos
Copy link
Owner

Clooos commented Apr 15, 2024

This issue should be finally fixed in the v2 beta! Can anyone confirm this?

Here is the link to the full changelog:
https://github.com/Clooos/Bubble-Card/releases/tag/v2.0.0-beta.1

@Nazze
Copy link
Author

Nazze commented Apr 15, 2024

So far I did not see it. But I will test for a few days. I recommend to close this ticket and reopen, when it shows up again. The new beta is a great piece of work.

@Nazze Nazze closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants