Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol files for ClosedXML are missing from Nuget #2070

Closed
2 of 6 tasks
zclimber opened this issue Apr 24, 2023 · 4 comments · Fixed by #2204
Closed
2 of 6 tasks

Symbol files for ClosedXML are missing from Nuget #2070

zclimber opened this issue Apr 24, 2023 · 4 comments · Fixed by #2204
Milestone

Comments

@zclimber
Copy link

Read and complete the full issue template

Do not randomly delete sections. They are here for a reason.

Do you want to request a feature or report a bug?

  • Bug
  • Feature
  • Question

Did you test against the latest CI build?

  • Yes
  • No

If you answered No, please test with the latest development build first.

Version of ClosedXML

e.g. 0.101.0

What is the current behavior?

Symbols are missing from Nuget download server.

What is the expected behavior or new feature?

Symbols are present at Nuget download server.

Is this a regression from the previous version?

Symbols were present in nuget package for v0.96.0

Reproducibility

Status for v101 https://nuget.info/packages/ClosedXML/0.101.0
Status for v96 https://nuget.info/packages/ClosedXML/0.96.0 - packets are present in nuget package, though not in nuget symbol server.
Also, you can try to download symbols with dotnet-symbols:

dotnet-symbol --server-path https://symbols.nuget.org/download/symbols ClosedXML.dll
Downloading from https://symbols.nuget.org/download/symbols/
ERROR: 403 Forbidden: ClosedXML.pdb - 'https://symbols.nuget.org/download/symbols/closedxml.pdb/b5c4abaffdd049d5ac7ba9c901391a3cFFFFFFFF/closedxml.pdb'
  • I attached a sample spreadsheet. (You can drag files on to this issue)
@jahav
Copy link
Member

jahav commented Oct 26, 2023

image

It seems Fody screws up PDB checksums (jbevain/cecil#610).

@jahav jahav reopened this Oct 26, 2023
@MagicAndre1981
Copy link

add DotNet.ReproducibleBuilds which enables reproducible builds and embedded the PDBs with source link:

<ItemGroup>
  <PackageReference Include="DotNet.ReproducibleBuilds" Version="1.1.1" PrivateAssets="All"/>
</ItemGroup>

@jahav
Copy link
Member

jahav commented Oct 26, 2023

Ok, let's hope it works. At least the package now includes pdb and should point to github sources.

This was rather frustrating experience... hard to test it locally (at least I couldn't) and dubious benefits of Source Link. Gain smaller size of pdb and in exchange hope that third party service (github) never goes down.... Way of the future I guess.

image

@jahav jahav closed this as completed Oct 26, 2023
@arashberlin
Copy link

Hi, when you plan to release the v0.104?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants