Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested objects in template_properties #15

Open
pop opened this issue Jan 8, 2021 · 1 comment
Open

Support nested objects in template_properties #15

pop opened this issue Jan 8, 2021 · 1 comment

Comments

@pop
Copy link
Contributor

pop commented Jan 8, 2021

template_properties in the provider can only support key(string):value(string) pairs. The backing API can support key(string):value(any) pairs, like this:

{
    "someKey": {
        "nestedValue": ["thing", "thing", "thing"]
    },
    "someOtherKey": "value",
    "finallyKey": ["stuff"]
}

To support arbitrary key:value pairs we need to change template_properties from a Terraform Map to a String of JSON. Similar to how the aws_iam_policy resource does things: reference.

This is a breaking change so we're not going to make it lightly. If you have concerns about this change let us know. If necessary, we will support two workflows for a while with a deprecation period for the old map-based template_properties.

@pop
Copy link
Contributor Author

pop commented Jan 8, 2021

To elaborate on the "supporting two workflows": We would probably add a new field, maybe called template_props which is the new "String of JSON" field. The old template_properties would then be marked as deprecated and removed in a later release.

Here's some info about how to deprecate attributes in a Terraform provider: reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant