New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undefined title #134
Comments
Hello! 👋 First a quick Q — how many pages are you indexing that takes an hour? (Also, what system are you running on?1) As for the titles, Pagefind pulls the Pagefind UI uses the value of the <title data-pagefind-meta="title">My Title</title> Footnotes
|
I have about 100k, and they're compressed. I mirrored my files using named pipes that feed each file into zcat when read, so that pagefind can read them. I'm running on Ubuntu 20.
Yeah, that's what I figured. I understand your rationale. Although it would be nice to be able to configure that in Pagefind. In my case, it would be a huge hassle to either regenerate every single html document (each is large and takes about ~5min to render). I could write a script to parse and edit them in-place, but that's also cumbersome. Being able to modify Pagefind's default title lookup would save me hours, or possibly days of coding. Having redundant stuff in the title isn't a big deal in my case. I don't have much redundant text and using the result processor callback, what little I do can be easily cleaned up on demand. |
Sounds good — I'll whip up exposing that as an option in the same PR for gzip handing (#135) which together should provide some great QOL improvements for your setup. |
Actually, in the interest of keeping the available options lean I'll get Pagefind to automatically fall back to |
Thanks. That gzip support looks like it would help tremendously. |
Hi @chrisspen 👋 A fallback to the |
Let me just say great job on Pagefind's performance.
Although it was difficult for me to index all my pages (took about an hour), the resulting index is very fast to search and looks great.
However, all my search results are showing up with an "undefined" title. How do I correct this?
My html has a valid <title> tag in every page. Is this not automatically pulled as the title?
The text was updated successfully, but these errors were encountered: