Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual desync issue with other players falling #102

Closed
rssujay opened this issue Mar 31, 2022 · 2 comments · Fixed by #117
Closed

Visual desync issue with other players falling #102

rssujay opened this issue Mar 31, 2022 · 2 comments · Fixed by #117
Labels
bug Something isn't working

Comments

@rssujay
Copy link
Collaborator

rssujay commented Mar 31, 2022

Sometimes, when a non-device (networked) player is falling, they appear to be falling in slow-motion and teleporting back up.

  1. Determined to not be an issue with network updates (yellow = expected behaviour, red = issue noticed)
    image

  2. explored @jushg's theory, that differences in screen sizes causes foreign player entity to collide with local entities, such as clouds, which may be in different positions under absolute (x, y) positioning.

Switching to relative positioning can mitigate the issue, unlikely to solve due to loss of accuracy during conversion, as well as current plans to only resolve via scaling width. If this is something we can live with, that's okay.

Considered other possibilities:

  • Should player entities from other devices be affected by local device non-player entities?
  • Should player entities from other devices be affected by local device gravity?

An approach that looks like this also appears to fix the issue:
image

@rssujay rssujay added the bug Something isn't working label Mar 31, 2022
@jushg
Copy link
Collaborator

jushg commented Mar 31, 2022

If the speculation above is correct, then an issue with visual desync when a player respawn in #96 will also be fixed

@jushg
Copy link
Collaborator

jushg commented Mar 31, 2022

As for other possibilities you mentioned, I believe that we should maintain the gravity (to make the UI smoother in case any one player is lagging). However, the player affect by other player should be changed, as it currently leads to a funny situation when a player standing on top of another player on a cloud is valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants