fix: Enable runner updates by default #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laxgoalie392
changed the title
|
Thanks! After sleeping on it, I am now even more sure we should only disable updates when the user sets a specific runner version. It will be easier to use this way. I have it almost ready. The integration test is running now. I'm sorry for not letting you know sooner. |
|
No worries! It took almost no time to put together the changes for this PR. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
Some GitHub Enterprise instances forbid runners from using --disableupdate. We only truly need it when a user a chooses a specific runner version. When we update the runner image with its version every week, disabling updates shouldn't matter anyway. GitHub Actions seems to only auto-update the runner if we're two versions behind and that would be very rare in the span of a week (default image rebuild interval). Originally we wanted to disable auto-updates because our runners are ephemeral and updating them for every single job would be wasteful. Since they only auto-update if we're two versions behind, I feel like we can drop this flag. Fixes #112 Replaces #120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
Disabling updates turned off by default per the convo in that issue.
I'm working through some cdk unit tests now but i wanted to get this out there for an initial review