Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GitHub Enterprise setup fails while complaining about "public": "false" #145

Merged
merged 3 commits into from Nov 7, 2022

Conversation

kichik
Copy link
Member

@kichik kichik commented Nov 7, 2022

We were always sending the string "false" as public in the manifest because the binding was wrong. It's supposed to be a boolean. GitHub was not happy about it and failed to create the app.

We were always sending the string `"false"` as `public` in the manifest because the binding was wrong. It's supposed to be a boolean. GitHub was not happy about it and failed to create the app.
@kichik kichik changed the title fix: GitHub Enterprise setup fix: GitHub Enterprise setup failed on "public": "false" Nov 7, 2022
@kichik kichik changed the title fix: GitHub Enterprise setup failed on "public": "false" fix: GitHub Enterprise setup fails while complaining about "public": "false" Nov 7, 2022
@mergify mergify bot merged commit ec0c20c into main Nov 7, 2022
@mergify mergify bot deleted the fix-ghes-setup branch November 7, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant