Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container vulnerabilities #149

Closed
pharindoko opened this issue Nov 11, 2022 · 7 comments
Closed

fix: container vulnerabilities #149

pharindoko opened this issue Nov 11, 2022 · 7 comments

Comments

@pharindoko
Copy link
Contributor

Hey,

I use codebuild for my runners and the default linux image (no custom image) provided.
Ecr has the capability to do a vulnerability scan (https://docs.aws.amazon.com/AmazonECR/latest/userguide/image-scanning.html).
I found a lot of critical security vulnerabilities inside of the container image.
Do you have a clue why ?

br,

flo

@kichik
Copy link
Member

kichik commented Nov 12, 2022

That's really weird. We run apt upgrade on every image build. Which vulnerabilities is it complaining about?

@pharindoko
Copy link
Contributor Author

pharindoko commented Nov 13, 2022

for example:

Name
parse-url

Installed version / Fixed version
/ Not available

Package manager
NPM

File path
home/runner/externals/node12/lib/node_modules/npm/docs/package-lock.json

most of the errors seem to be related to this externals/node12 directory...

@kichik
Copy link
Member

kichik commented Nov 13, 2022

That's part of https://github.com/actions/runner. I'm not sure we can do more than open a ticket for them to update it.

@pharindoko
Copy link
Contributor Author

yes figured out the same. There`s already an issue open ... actions/runner#2145

@kichik
Copy link
Member

kichik commented Nov 13, 2022

I'm surprised it has so little upvotes.

@pharindoko
Copy link
Contributor Author

same opinion - but would have expected that gh keeps it more up to date....
we talk about 16 critical and 123 high vulnerabilities that the ecr image scan found ...

@kichik
Copy link
Member

kichik commented Nov 14, 2022

Maybe this will be resolved once Node 12 is completely removed. It's already deprecated. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants