Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Overlong agentName error from GitHub #23

Closed
wants to merge 3 commits into from

Conversation

QuinnyPig
Copy link
Contributor

Ran into an issue where my org name + project name were 66 characters; GitHub errors if it's more than 64. This truncates that edge case at the cost of a couple bits of entropy from a UUID.

@QuinnyPig QuinnyPig changed the title Fix: Overlong agentName error from GitHub fix: Overlong agentName error from GitHub May 31, 2022
@kichik
Copy link
Member

kichik commented May 31, 2022

This will break the delete task. That means the runner can stay after Lambda times out or fails for another reason. We may need to use a step to trim it or just trim everywhere it's used.

@QuinnyPig
Copy link
Contributor Author

Yeah, it looks like right around here is where it should get fixed if truncating it everywhere is the solution:

const runnerId = await getRunnerId(octokit, event.owner, event.repo, event.runnerName);

My JS-foo is weak here.

@QuinnyPig
Copy link
Contributor Author

Ran it down and applied it everywhere I found it being used. Tested working here.

@kichik kichik closed this in de21af1 Jun 1, 2022
@QuinnyPig QuinnyPig deleted the agentname branch June 1, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants