Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace deprecated property for cleaning up ECR repositories #538

Conversation

jonathanmorley
Copy link

No description provided.

@jonathanmorley jonathanmorley force-pushed the replace-deprecated-ecr-cleanup-prop branch from 2da21bb to 32d49a8 Compare April 25, 2024 15:05
@jonathanmorley jonathanmorley force-pushed the replace-deprecated-ecr-cleanup-prop branch from 32d49a8 to e33983a Compare April 25, 2024 15:06
@kichik
Copy link
Member

kichik commented Apr 25, 2024

emptyOnDelete is awesome, but it requires CDK v2.116.0 while we still support v2.111.0.

cdkVersion: '2.110.0', // 2.21.1 for lambda url, 2.29.0 for Names.uniqueResourceName(), 2.50.0 for JsonPath.base64Encode, 2.77.0 for node 16, 2.110.0 for ib lifecycle

I will merge this once we upgrade.

@kichik kichik changed the title fix: replace the deprecated property for cleaning up ECR repositories fix: Replace deprecated property for cleaning up ECR repositories May 4, 2024
@kichik
Copy link
Member

kichik commented May 4, 2024

Do you have an option to let me push to this branch? I am unable to update it with the latest snapshot. Alternatively, can you merge main, npm run integ:default:snapshot and push?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants