-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows ec2 doesn`t reach the stop state in ec2 userdata script #570
Comments
I'm not PowerShell expert, but I do believe we are already doing that. Are you sure these are the logs of the right instance? It seems like a log of a runner that the idle reaper terminated. In that case, the step function execution should have also been aborted. |
Yes I'm very sure that it's the right instance. We were able to replicate the issue running the same job again. Try catch in powershell: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_try_catch_finally?view=powershell-7.4 |
Would you be able pull up the user data log from that machine so I can better understand what exactly failed there? It should be in |
couldn`t find the UserdataExecution.log ... aws mentions it here ....
guess we use |
Hey @kichik,
I had one special use case which I can replicate.
While the job has been successfully completed in github, the ec2 instance and the step function job execution are still running.
runner.log
What`s the problem:
The machine is still running and we waste money until we recognize it. (yes additional alerting in this case would make sense too but I haven`t yet in place.)
Proposal:
It would be great to have a try catch block around the action statement in powershell
cdk-github-runners/src/providers/ec2.ts
Line 165 in f08da20
to ensure the machine get`s terminated
cdk-github-runners/src/providers/ec2.ts
Line 172 in f08da20
The text was updated successfully, but these errors were encountered: