Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseMicro and microCOM classes [COM branch] #4

Open
sudogauss opened this issue Jan 28, 2023 · 1 comment
Open

BaseMicro and microCOM classes [COM branch] #4

sudogauss opened this issue Jan 28, 2023 · 1 comment

Comments

@sudogauss
Copy link

Is there real necessity to have two microcontroller classes? In plus microCOM.py and a class inside it don't have the same name. repr method seems to be very strange. Move ORDER_LENGTH and FEEDBACK_LENGTH to consts.

make_message use a very tricky float to int bit conversion (inspired by fast inverse square root I suppose). Why not to use fixed point integer for floats?

The endianness choice must me in constructor.

Note : There is a separate issue for BaseMicro.py

@EKnight-Blue
Copy link
Collaborator

There is a parent class and two classes inherit from it: MicroProc and Shell as they are two different use of the BaseMicro class.
Indeed __repr__ is strange. Fair point about the constants

make_message does not use this trick, the code on the pico size does (well guessed). As I do not know the range needed for variables, and as I can send floatting point numbers I prefer to ensure that every value can be sent and received

Typo ?

Where ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants