Define constants for field names and statuses

[jml]

Rather than using anything nice like Python 3.4's enum or twisted.python.constants, I've just defined a bunch of variables with similar-looking names. I think this makes the code more readable and makes some of the structure of eliot more explicit.

I haven't updated usage in tests, but can if you'd like.

[itamarst]

Perhaps these should also be part of the public API?

[jml]

Happy to do that, perhaps as a separate patch?

[jml]

Actually, now I think making APIs public should definitely be part of a separate patch. Now that constantly is released I'd like to look at using it. I did a quick experiment with switching the various STATUS fields to be ValueConstant and noticed two things:

1. SUCCEEDED_STATUS et. al. get renamed to STATUS.SUCCEEDED etc. (which would break a public API)
2. Serialization starts to fail with exceptions.TypeError: <STATUS=STARTED> is not JSON serializable

[itamarst]

You'd need to use STATUS.SUCCEEDED.value to prevent the serialization problems.

[itamarst]

Thanks, definitely an improvement.

[jml]

Yeah, but it's not just a simple matter of adding .value somewhere. It's
also finding the right places to hook into the two JSON serialization
mechanisms and converting the constants into the right form wherever we may
find them.

On Fri, 14 Aug 2015 at 21:35 Itamar Turner-Trauring <
notifications@github.com> wrote:

You'd need to use STATUS.SUCCEEDED.value to prevent the serialization
problems.

—
Reply to this email directly or view it on GitHub
#200 (comment).