bashism in pgsql

[ktosiek]

The pgsql agent has /bin/sh in a hashbang, and uses ${variable//match/replace/} syntax at

resource-agents/heartbeat/pgsql

Line 1654 in 733a472

sed -i "/${rep_mode_string//\//\\/}/d" $OCF_RESKEY_config

.
This syntax does not work in dash (which is default /bin/sh in Ubuntu), I think it's bash-specific. Can either the replace or the hashbang be changed?

[kskmori]

Thanks for pointing out.
You're right, we had missed to run checkbashisms before applying this particular patch.
I'm going to fix it.

[knakahira]

Hi ktosiek,
I made a patch for this issue.
knakahira@572c32a
Please test it in your environment and tell me if you have any problems.

[kskmori]

Closing as it is fixed in #411.