Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two SNES .sfrom headers can be one #461

Closed
anpage opened this issue Oct 5, 2017 · 5 comments
Closed

Two SNES .sfrom headers can be one #461

anpage opened this issue Oct 5, 2017 · 5 comments

Comments

@anpage
Copy link

anpage commented Oct 5, 2017

@pcm720 and I determined that as long as you point to the right location in offsets 0x08 and 0x14 of the header, the second half can be appended to the first to make one continuous header at the beginning. This should greatly simplify the conversion portion of hakchi2.

See our comments here

@gnadenlos
Copy link

Or you can break something we don't fully understand yet, like you did with the 2P feature. Why should we want to use different headers/footers than Nintendo does for their own games?

@anpage
Copy link
Author

anpage commented Oct 6, 2017

like you did with the 2P feature

Unrelated to combining the header and footer.

Why should we want to use different headers/footers than Nintendo does for their own games?

They're not different, just in a different place. Plus, if I'm not mistaken, the 3DS combines them too.

@barryvdh
Copy link
Contributor

barryvdh commented Oct 8, 2017

So does this have better results, or just simpler conversion? (See #539)

Otherwise it would be cool to see a PR for this :)

@anpage
Copy link
Author

anpage commented Oct 8, 2017

It could potentially have better results, but as far as I know all it would do is simplify things. For me, during my research, having both the header and footer in one place made reading and editing the header by hand with a hex editor much easier.

I'll work on a PR if @ClusterM decides that's sometihng he wants.

@Drakonas
Copy link
Collaborator

These issues should have been resolved. Please respond if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants