-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two SNES .sfrom headers can be one #461
Comments
Or you can break something we don't fully understand yet, like you did with the 2P feature. Why should we want to use different headers/footers than Nintendo does for their own games? |
Unrelated to combining the header and footer.
They're not different, just in a different place. Plus, if I'm not mistaken, the 3DS combines them too. |
So does this have better results, or just simpler conversion? (See #539) Otherwise it would be cool to see a PR for this :) |
It could potentially have better results, but as far as I know all it would do is simplify things. For me, during my research, having both the header and footer in one place made reading and editing the header by hand with a hex editor much easier. I'll work on a PR if @ClusterM decides that's sometihng he wants. |
These issues should have been resolved. Please respond if not. |
@pcm720 and I determined that as long as you point to the right location in offsets 0x08 and 0x14 of the header, the second half can be appended to the first to make one continuous header at the beginning. This should greatly simplify the conversion portion of hakchi2.
See our comments here
The text was updated successfully, but these errors were encountered: