Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build from latest commit #95

Closed
stayupthetree opened this issue Feb 15, 2017 · 32 comments
Closed

Unable to build from latest commit #95

stayupthetree opened this issue Feb 15, 2017 · 32 comments

Comments

@stayupthetree
Copy link

I get the following 4 errors from Visual Studio when trying to build. http://prntscr.com/e9a35n

@sanjay900
Copy link
Contributor

I get the same. I have a feeling some files were not pushed.

@sanjay900
Copy link
Contributor

Still have the same problem after 05c4801

@sanjay900
Copy link
Contributor

Still a problem after a860691

@retinoic
Copy link

several of the necessary files can be found on madmonkey's hakchi repo in /mod/hakchi, with the exception of rsync

@sanjay900
Copy link
Contributor

Yeah, but even then, we need rsync for any of this to work.
also, still broken as of 8c4af66

@sanjay900
Copy link
Contributor

I think the issue here is that the .gitignore is ignoring all bin folders, which means that all the bin folders that should be being uploaded are being ignored.

@sanjay900
Copy link
Contributor

sanjay900 commented Feb 17, 2017

By accident, it looks bin/ was added to the .gitignore and this is excluding all bin folders which really isnt helpful. this is also why all the bin files are missing from the retroarch mod as well.

@sanjay900
Copy link
Contributor

#98

@sanjay900
Copy link
Contributor

That would explain why the issue never appeared for @ClusterM and why it has not been solved in the last few commits.

@bobskorn
Copy link

I still can get it to build after patch @sanjay900 still getting missing file errors

@sanjay900
Copy link
Contributor

sanjay900 commented Feb 17, 2017

Yeah, this is something @ClusterM needs to do accept, then he needs to push.
Essentially, without the patch, git is stopping him from uploading the required files for us to compile.
Only @ClusterM has the files we need, i can't be bothered trying to compile rsync myself.

@bobskorn
Copy link

Ah I see. Thanks for figuring it out!

@sanjay900
Copy link
Contributor

I had an issue where something like this happened to me, so i figured id look into it haha

@sanjay900
Copy link
Contributor

sanjay900 commented Feb 17, 2017

I just really want this retroarch mod haha, im curious how he got it to work with the built in save system

@bobskorn
Copy link

You and me both my friend.

@NoCodeLeftBehind
Copy link
Contributor

The GitHub Desktop app provided a default .gitignore that excludes /bin. Without it, when you use the app to try to sync your fork to the origin, it treats all of the files that end up being generated in /bin/Debug or /bin/Release during compilation as changed files. While the default .gitignore worked to properly exclude those, it sounds like it unfortunately also caught up files in other /bin sub-folders such as the Linux executables that are needed.

@sanjay900
Copy link
Contributor

Oh i see, what you want to ignore then is /bin not bin/

@bobskorn
Copy link

@sanjay900 did you get the new commit to build properly? I'm still getting errors in Visual Studio

@sanjay900
Copy link
Contributor

Yeah, that are now files missing from tar. Thats easy to fix though, im just copying tar from git bash.

@bobskorn
Copy link

Can you tell me how?

@sanjay900
Copy link
Contributor

sanjay900 commented Feb 17, 2017

Assuming you have git bash installed
go into project -> hakchi_gui properties -> build events
then replace the pre command with

set PATH="C:\Program Files\Git\usr\bin"
cd $(ProjectDir)user_mods\retroarch.hmod
bash -c "tar -czvf retroarch.hmod *"
mkdir "$(TargetDir)user_mods\"
move /Y "$(ProjectDir)user_mods\retroarch.hmod\retroarch.hmod" "$(TargetDir)user_mods\"

It was proving way too much of a hassle to decouple tar from bash, so im just running it in bash until we get a proper fix. It now compiles and runs with that change.

At the end of the day, the current problem is that a dll file called msys-1.0.dll is missing.

@bobskorn
Copy link

I didn't but I will in a min thanks

@stepik
Copy link

stepik commented Feb 17, 2017

Cluster added missed files

@stayupthetree
Copy link
Author

Still won't build

@sanjay900
Copy link
Contributor

sanjay900 commented Feb 18, 2017

Then again, when i use this build, my nes bootloops, so i dont know what to do at this point.
And that happens even if all i upload is a single nes game. Which means it is not retroarch causing problems.

@stayupthetree
Copy link
Author

stayupthetree commented Feb 18, 2017

I can't even get an executable out of it, so you are at least further than me

@bobskorn
Copy link

me either

@sanjay900
Copy link
Contributor

If you still can't get this to work, the other option is to just delete the build step entirely and just make the tarball yourself and drop it in.

@ajmi982
Copy link

ajmi982 commented Feb 18, 2017

can you explain that last comment sanjay900? Im about to try your comment from 4 hours ago.

@ajmi982
Copy link

ajmi982 commented Feb 18, 2017

I have gitbash installed but i cant find "go into project -> hakchi_gui properties -> build events" inside Visual STudio

@bobskorn
Copy link

@sanjay900 I followed your instructions but just did it in Visual Studio and it worked like a champ!!! Thanks bud.

@ClusterM
Copy link
Owner

Fixed. Sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants